Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)

ekr <notifications@github.com> Thu, 20 December 2018 23:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D47413128E for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 15:58:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pk0Uy15GgMp2 for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 15:58:45 -0800 (PST)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC88313128D for <quic-issues@ietf.org>; Thu, 20 Dec 2018 15:58:45 -0800 (PST)
Date: Thu, 20 Dec 2018 15:58:44 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545350325; bh=XdtiwuKomseAB8083lQLqTX11tVZVJKg/bKph5fxd28=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yUdwdR2/lp/ie5hzk7vgYKqstjSdwWcz4yCsxXvPnDSFGfEtuyULP95D5yI0Iju73 3xmda0l13GH+91ecwNOD2bOm+zwfe61kCmeIoMBkhLlRQZdenz725HLi54ztkqeImx 6OeOZ0s0oz/oFjvg0Y5wtq0NyqL6vw+9oveU93cQ=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1592b0b6d78829ce1c2b9607f9ff5edc41fa023092cf000000011833eeb492a169ce17707fcb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2235/c449181703@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2235@github.com>
References: <quicwg/base-drafts/pull/2235@github.com>
Subject: Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1c2cb4e7d3b_add3f86a5ed45c088578"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z8zRk28fsDPSXL1oD9kJUZ0Syjc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 23:58:47 -0000

I would be fine with type being a VLI.

On Thu, Dec 20, 2018 at 3:57 PM David Schinazi <notifications@github.com>
wrote:

> I like this. You could imagine reserving a part of the type space (e.g.
> 0-32) for non-TLV frames, and if you ever receive something in that range
> that you don't understand you fail the connection. But if you receive a TLV
> type you don't understand, you can safely ignore it since you know how long
> it is.
>
> Minor: I'd make the type a variable-length integer
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/pull/2235#issuecomment-449181514>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABD1oVtlQi7p7siJy9Y9WKwIWjwPPuL6ks5u7CPmgaJpZM4ZdEz2>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2235#issuecomment-449181703