Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)

Mike Bishop <notifications@github.com> Mon, 07 January 2019 20:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A16F3126DBF for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 12:59:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3j5Rxdd1Zdad for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 12:59:35 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 024C3124D68 for <quic-issues@ietf.org>; Mon, 7 Jan 2019 12:59:34 -0800 (PST)
Date: Mon, 07 Jan 2019 12:59:34 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546894774; bh=wgFN5Tem9vx4dyUiRNN9ZeyEFpciHzmBfJGL3+2cCT4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=H/vKmesqvCLPqtQ4wd8mrRvsdj9oqQPylCEH3CFFc75rhAEqIQQoKLPUToM8wTNCn 0EcfLQ/Q5ZTB4nR7BjD7uCQ4MavcZKN73dN40DVX11qes/iRaKDCFuHWIllSFwUw6j k5/4+B+bcrSAS5RUV22HAQodODdpeoQOfDPQKq/w=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcf5f0d8713e209f56840a932b001c2b0bdac0ba892cf00000001184b7fb692a169ce17707fcb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2235/c452079678@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2235@github.com>
References: <quicwg/base-drafts/pull/2235@github.com>
Subject: Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c33bdb62c06a_3d903fdafd8d45c425129e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_5hKMNy4pJlGxYdN8vsKciADYjw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 20:59:37 -0000

The previous discussion was #1351.  The conclusion there was that the order doesn't matter a great deal (under the assumption that you need both), and so consistency with HTTP/2 was the tie-break.

If there's a desire to enable length-less frames, that's an argument for TLV.  However, I don't think switching on the type value first is terribly compelling -- there doesn't seem to be a great difference between:
- passing your frame parser the type and expecting it to tell you how many bytes of the stream it processed and whether the frame was valid
- passing your frame parser the type and length and expecting it to tell you if the frame was mis-sized

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2235#issuecomment-452079678