IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)

Lucas Pardue <notifications@github.com> Sun, 23 December 2018 12:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8ED171294D0 for <quic-issues@ietfa.amsl.com>; Sun, 23 Dec 2018 04:04:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l0nflfVvEUUc for <quic-issues@ietfa.amsl.com>; Sun, 23 Dec 2018 04:04:32 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF000126CB6 for <quic-issues@ietf.org>; Sun, 23 Dec 2018 04:04:31 -0800 (PST)
Date: Sun, 23 Dec 2018 04:04:30 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545566670; bh=deufXNVHtgwfmuylrwIrxi10Ieu7WqgAOOoSY3NAGrk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hcHU7lBEkaMgyB7h6V7HCpt4HX0VejjRhIm5bbJDDR9sjmH+cJyfim+AhPEa0uITo 88JEd1I7tDv4SseVm8oM4AIo9FMuboe9Vup824oR9hgKprsqF7zt/uBbF2EWzatCk5 I8unmRK4QJbgbcDMdf7RmSEYgxfXHqRhVbQrlhsw=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb33b96615ed8ce108d2fd7c9514ac1b9f1b1fb7f92cf0000000118373bce92a169ce17707fcb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2235/c449632012@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2235@github.com>
References: <quicwg/base-drafts/pull/2235@github.com>
Subject: Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1f79ce95e59_28673fcadeed45c0619129"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eBim5pBTokLSq0AWMC7Z0xS8hhU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Dec 2018 12:04:34 -0000

I'm not sure about omitting length. I can see there could be benefit in stating that some frame types, that are part of H3 core, which contain only varints could be optimised by not including the length. 

However, from an implementation perspective it seems simpler to have code that can read frames out of the stream using the frame length. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2235#issuecomment-449632012

v2.23.0 | Report a Bug | By Email