IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)

janaiyengar <notifications@github.com> Fri, 04 January 2019 01:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 673991313B4 for <quic-issues@ietfa.amsl.com>; Thu, 3 Jan 2019 17:05:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WFF8pW7U8hyB for <quic-issues@ietfa.amsl.com>; Thu, 3 Jan 2019 17:05:52 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2035913139E for <quic-issues@ietf.org>; Thu, 3 Jan 2019 17:05:52 -0800 (PST)
Date: Thu, 03 Jan 2019 17:05:51 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546563951; bh=uejnspBtMTzw1Sfr2Bz2HwNO3dmIH3vv0Hmevm2gq5g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KZBLdKP2t8gewLO18zXhuhT7Gq83FdvJVe0+iKtFoRkhQ7PKby/FumtVsYG1GFoax gxi6vD2xl6jZlGdt5xadwjf0J4e7X/58Xn8eQiWIECy9uRh0Sfd9s/0Qnue/cE/olb A1K4ckesqUw82wOee34SUZ69v2FaiFiubWEJFTSY=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab013e9788aeeb3cfa74336ce2e41cea8a94e6654592cf000000011846736f92a169ce17707fcb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2235/c451327554@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2235@github.com>
References: <quicwg/base-drafts/pull/2235@github.com>
Subject: Re: [quicwg/base-drafts] Make HTTP frames a TLV format. This has several advantages: (#2235)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c2eb16f6e721_5ad53fad412d45b4171190"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jqSyITuS5ztZaj2i-YKWvyGGUjk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 01:05:53 -0000

I wasn't in the room where it happened, but I can imagine one reason for doing LTV in HTTP/2 might have been that you need to read out frames from the underlying byte-stream before demuxing and parsing them. A frame reader only needs Length before reading out the entire frame and passing it on to the parser. QUIC is different in that the entire frame is present when the length is read.

I think this is a simple enough change, and there are straightforward benefits. We expect to see some changes with more implementation experience in the HTTP mapping, so I'd like to push for this PR.

@ekr -- this discussion should be happening on an issue. Can you open an issue ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2235#issuecomment-451327554

v2.23.0 | Report a Bug | By Email