Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)
janaiyengar <notifications@github.com> Tue, 02 October 2018 15:53 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2DF45130E44 for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 08:53:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.456
X-Spam-Level:
X-Spam-Status: No, score=-8.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BG-LeogsvpyV for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 08:53:13 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 606FF130E16 for <quic-issues@ietf.org>; Tue, 2 Oct 2018 08:53:13 -0700 (PDT)
Date: Tue, 02 Oct 2018 08:53:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538495592; bh=nVPrkNlXtITcOs7ZLnlVtakwDVFVKJmzge8t9isJNrk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Jkyy37wG6fS29mEXTD9epUdiwvwaoMWa9dWYrtYExjytK7kscG8Dn3vGIXHBBIb1O j9StyBxqi3qW2s8Aj2YLSeQXibyuY/QbmaSb2p24sNPd0MezigRhHiLe7qI4JEikMs v8Fn/oiyWJLFFN6DExfOzKdmvoHpgkZfBBNLqm2U=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab83c9916ee31f542ec739808162ecb057d2207e5692cf0000000117cb566892a169ce15ac2c4e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1796/review/160794798@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1796@github.com>
References: <quicwg/base-drafts/pull/1796@github.com>
Subject: Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb3946820497_48253fc2668d45c44705c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dT095mwnePtgCQRWllppsIhatYc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 15:53:15 -0000
janaiyengar commented on this pull request. > @@ -446,16 +433,16 @@ flight, since this packet adds network load without establishing packet loss. ## Generating Acknowledgements QUIC SHOULD delay sending acknowledgements in response to packets, but MUST NOT -excessively delay acknowledgements of packets containing frames other than ACK -or ACN_ECN. Specifically, implementations MUST attempt to enforce a maximum -ack delay to avoid causing the peer spurious timeouts. The RECOMMENDED maximum -ack delay in QUIC is 25ms. - -An acknowledgement MAY be sent for every second full-sized packet, as TCP does -{{?RFC5681}}, or may be sent less frequently, as long as the delay does not -exceed the maximum ack delay. QUIC recovery algorithms do not assume the peer -generates an acknowledgement immediately when receiving a second full-sized -packet. +excessively delay acknowledgements of packets containing frames other than ACK. +Specifically, implementations MUST attempt to enforce a maximum +ack delay to avoid causing the peer spurious timeouts. The maximum ack delay +is communicated in the `max_ack_delay` transport parameter and the default s/default/RECOMMENDED -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1796#pullrequestreview-160794798
- [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) Nick Banks
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) Nick Banks
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) Rui Paulo
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) Rui Paulo
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) MikkelFJ
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) ianswett
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) janaiyengar
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) janaiyengar
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) janaiyengar
- Re: [quicwg/base-drafts] Ack Delay and TLP (#1796) janaiyengar