IETF Logo Mail Archive

Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)

Nick Banks <notifications@github.com> Tue, 25 September 2018 17:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA5D8130E26 for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 10:00:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.455
X-Spam-Level:
X-Spam-Status: No, score=-8.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KC9owjss__zq for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 10:00:30 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0746130E22 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 10:00:29 -0700 (PDT)
Date: Tue, 25 Sep 2018 10:00:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537894829; bh=h2tT71sKDTzp1dyHyvFU0dt2JVmFac1URdkFiCtQ4mM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=y6qxuKZRZROGLw/852CJb5FRzg8Da3oGHwyth05umwaoR8Ih+UmNGpHNXDWGa3D4J 0lsAJa4AzTkFwRMInSZSNKclxep2z3SNhbjOPDZ6VN3KCTxb6+iC+lB13R4LoGdJZW FcIl+1jOzHcQP3H5WsghEQTr5kTiY5cRVc9+FfAo=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7efe9f457f26ecb0ad0aafdd8f221416283ab34d92cf0000000117c22bac92a169ce15ac2c4e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1796/review/158642271@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1796@github.com>
References: <quicwg/base-drafts/pull/1796@github.com>
Subject: Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5baa69acebfc2_1c213f95e1cd45b829789f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cCd1R98NI0X3Qh0QK4FzPY7i6as>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 17:00:32 -0000

nibanks commented on this pull request.



> @@ -365,7 +352,11 @@ receiver.
 The timer duration, or Probe Timeout (PTO), is set based on the following
 conditions:
 
-* PTO SHOULD be scheduled for max(1.5*SRTT+MaxAckDelay, kMinTLPTimeout)
+* If less than 2400 bytes are in flight, PTO SHOULD be scheduled for

So, is the receiver acknowledging based on byte count or packet count? I thought it was packet count. If so, then it seems to reason, the sender should do the same here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1796#discussion_r220272371

v2.23.0 | Report a Bug | By Email