Re: [quicwg/base-drafts] Editorial suggestions from Benjamin Kaduk's IESG review (qpack) (#4789)

[afrind <[e-mail]>]

@afrind commented on this pull request.



> @@ -1738,7 +1740,7 @@ Stream: Encoder
                               ^-- acknowledged --^
                                4   0  :authority  www.example.com
                                5   0  custom-key  custom-value2
-                              Size=215
+                              Size=214

Wait, let's go to the video tape!  I think 215 is correct.

I re-ran my decoder against the input, and it gets 215.

~~~
DecoderTable:

[1] (s=55) custom-key: custom-value2
[2] (s=57) :authority: www.example.com
[3] (s=54) custom-key: custom-value
[4] (s=49) :path: /sample/path
total size: 215
~~~
[Note: the decoder table prints with HPACK relative indices, hence they are 1 based and in reverse order]

Also verified in the shell:

~~~
# echo -n :authoritywww.example.com | wc -c
25
# echo -n custom-keycustom-value2 | wc -c
23
~~~

And third, I examined the table which has the two values in consecutive rows, and it appears only the "om" hangs over the 'custom-value2'.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4789#discussion_r565530977