Re: [quicwg/base-drafts] Add retry integrity tag (#3120)

Christian Huitema <notifications@github.com> Fri, 15 November 2019 08:05 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 95383120110 for <quic-issues@ietfa.amsl.com>; Fri, 15 Nov 2019 00:05:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.454
X-Spam-Level:
X-Spam-Status: No, score=-1.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RF77blWtS0x5 for <quic-issues@ietfa.amsl.com>; Fri, 15 Nov 2019 00:05:36 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 639F612010F for <quic-issues@ietf.org>; Fri, 15 Nov 2019 00:05:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=BxnN7nU3VT1yu895ex8ehEs+SeamxjgG4VCn8Ogy9HU=; b= Rr+WUcixchlN4ghFrl7tOWq+n2Wj48K0w0uu4Ffb50mWNxcYzj4cAzdr5m1fi23C TT60VYvagAS00vFGt0nawVpOvPoSrWZ613FCwTW6H9qBJatz51T4OCq5slmHJmVR XX0LPw5iYDgFGi/PqDVXp11S4Z0gaxjhbRtAGXaVi6s=
Received: by filter0509p1iad2.sendgrid.net with SMTP id filter0509p1iad2-29256-5DCE5C4F-E 2019-11-15 08:05:35.21190208 +0000 UTC m=+100409.494333499
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [140.82.115.4]) by ismtpd0045p1iad2.sendgrid.net (SG) with ESMTP id RUq9-RfoQeyI7oqK3eJMdw for <quic-issues@ietf.org>; Fri, 15 Nov 2019 08:05:35.154 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id 1637E160D48 for <quic-issues@ietf.org>; Fri, 15 Nov 2019 00:05:35 -0800 (PST)
Date: Fri, 15 Nov 2019 08:05:35 +0000 (UTC)
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY234KO6ZDSJSBH7OV33OHM7EVBNHHB4UZE54@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3120/review/317457632@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3120@github.com>
References: <quicwg/base-drafts/pull/3120@github.com>
Subject: Re: [quicwg/base-drafts] Add retry integrity tag (#3120)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dce5c4f14d47_3ffd3f82b04cd96c7151ad"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3MPCiohXav45K0/f9EgM+1ROV7jaqeJCH8id 5H5X1kGJ42mw7wnkveGcospN7ijf2eqzFlni7IHenyHaC/JvVyweLOpRXcvgxu7hCqroqsHqi+pK0V WmHgVCVgTJck3sHvxBPSoSiA8/V37+XCoHkxZPrYkbfZCP13LmJnJG7bPbKklWgKt5iJVi+SB2Kkjz 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kyc6la7AAuPbh93I8uThJzpGKzs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Nov 2019 08:05:38 -0000

huitema approved this pull request.

I may have sounded negative, but the protection against network errors alone justifies this PR. As long as we don't make foolhardy statements about mitigating attacks, I am fine.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3120#pullrequestreview-317457632