IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define INITIAL_PRIORITY frame and remove exclusive dependencies (#2075)

Mike Bishop <notifications@github.com> Fri, 30 November 2018 06:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ACEFC126CB6 for <quic-issues@ietfa.amsl.com>; Thu, 29 Nov 2018 22:59:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dg7V6BGerUA0 for <quic-issues@ietfa.amsl.com>; Thu, 29 Nov 2018 22:59:42 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E8F0F127332 for <quic-issues@ietf.org>; Thu, 29 Nov 2018 22:59:41 -0800 (PST)
Date: Thu, 29 Nov 2018 22:59:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543561180; bh=eT35552PrHMsoMGW3+a2oyMIDRWeOID6BuqvCwYwJhI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KHbolHwN6lbYyoHSgY0tlgmNi1Djsi69XDKkJD4/smGqT5n89HAwuBkSFyHwyzkCK jmtriH7mkOYaSxyjYyZ67PJHBp8GIoyCej8rgqAiEfp1n0880eUQyWnEm+XgPbUcdz XrG7ntR2N7Lf63BSmXMRomkycw8Pii0vezldJFjU=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab22766cffe7d4dc8ff943ad9b11446cf7fcdc951192cf000000011818a1dc92a169ce17019477@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2075/review/180140375@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2075@github.com>
References: <quicwg/base-drafts/pull/2075@github.com>
Subject: Re: [quicwg/base-drafts] Define INITIAL_PRIORITY frame and remove exclusive dependencies (#2075)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c00dfdcedc48_63cf3fb52d6d45bc43989f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mI76K9hhHmR9fV2zUgxy1CtqvQE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 06:59:44 -0000

MikeBishop commented on this pull request.



> @@ -496,13 +496,9 @@ The PRIORITY frame payload has the following fields:
   : A two-bit field indicating the type of element being depended on.
 
   Empty:
-  : A three-bit field which MUST be zero when sent and MUST be ignored
+  : A four-bit field which MUST be zero when sent and MUST be ignored
     on receipt.

If you don't, you risk an overzealous implementation enforcing the "MUST be zero" and we can't use it later without negotiation.  "MUST ignore" seems cleaner than "MUST not die in flames if it's not zero."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2075#discussion_r237762806

v2.23.0 | Report a Bug | By Email