IETF Logo Mail Archive

Re: [quicwg/base-drafts] Update DPLPMTUD and PMTUD (#3693)

Gorry Fairhurst <notifications@github.com> Mon, 25 May 2020 19:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 988043A09AA for <quic-issues@ietfa.amsl.com>; Mon, 25 May 2020 12:38:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id axmwaPBFpCeI for <quic-issues@ietfa.amsl.com>; Mon, 25 May 2020 12:38:42 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6516B3A0997 for <quic-issues@ietf.org>; Mon, 25 May 2020 12:38:42 -0700 (PDT)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 496DCE0B7A for <quic-issues@ietf.org>; Mon, 25 May 2020 12:38:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590435521; bh=OSCaGhnd2DOD5xG6fQuFQCtchcsv7ov1lrbeSqbTrio=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0rNcSV75FJEQYF8R5gf/hN3l1GF7p2dgFUTlL+PwXKsGNr1eHsPrJMdF1EZO6sGYw xsgfpEAZ3XYvLtN9gxyA/krJvxzm3JA9qJVmptOhn6dCptypf5Y31+nYpXyYLqUEnk Xmk95+5yS+jbMEYJQ4FuPPaR/HuDV04XTtgAQ228=
Date: Mon, 25 May 2020 12:38:41 -0700
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7IOEAO6K7FWZGFRBV42774DEVBNHHCKNQYNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3693/review/417855576@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3693@github.com>
References: <quicwg/base-drafts/pull/3693@github.com>
Subject: Re: [quicwg/base-drafts] Update DPLPMTUD and PMTUD (#3693)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ecc1ec137031_78c43fe579ecd968308985"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wXTQOjjhEORHW2Vo4Zwmk6dLTfE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 May 2020 19:38:48 -0000

@gorryfair commented on this pull request.



> @@ -3797,17 +3797,23 @@ later time in the connection.
 The QUIC packet size includes the QUIC header and protected payload, but not the
 UDP or IP header.
 
+QUIC defines the minimum QUIC packet size as at least 1280 bytes.

Fine, except shouldn't this be: /as at/of at/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3693#discussion_r430056597

v2.23.0 | Report a Bug | By Email