IETF Logo Mail Archive

Re: [quicwg/base-drafts] Move Generating Acknowledgements to Transport (#2916)

Martin Thomson <notifications@github.com> Wed, 11 September 2019 17:41 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB4A71208D1 for <quic-issues@ietfa.amsl.com>; Wed, 11 Sep 2019 10:41:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.622
X-Spam-Level:
X-Spam-Status: No, score=-1.622 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.026, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nl56iiy_3erX for <quic-issues@ietfa.amsl.com>; Wed, 11 Sep 2019 10:41:51 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8DB05120893 for <quic-issues@ietf.org>; Wed, 11 Sep 2019 10:41:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=o3cukBMAd72vnQEMY4Stndj4Jik=; b=Vu+lFFC4T+Z0854R kAUQRMJctrN7qLuTXPHOPGUk5lxd/o/UnNaXWQBcuRiVjvSiRrRiIFmgq9NM0Xvx /Up4bYNnRWAGCxE+MRhL86fAjJlDt4gToHh7SBhMvXUf53gt1yzoxs/DSyQI3y4b SspXm5fk2hYCaw//aI9WnQyvvP8=
Received: by filter1379p1mdw1.sendgrid.net with SMTP id filter1379p1mdw1-21181-5D7931DE-1D 2019-09-11 17:41:50.792740031 +0000 UTC m=+75798.938231099
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [140.82.115.66]) by ismtpd0040p1iad2.sendgrid.net (SG) with ESMTP id j82hb2RzRbqbjDMxhscYDQ for <quic-issues@ietf.org>; Wed, 11 Sep 2019 17:41:50.690 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id 9B040A80F0F for <quic-issues@ietf.org>; Wed, 11 Sep 2019 10:41:50 -0700 (PDT)
Date: Wed, 11 Sep 2019 17:41:50 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2EBSSGP2Q7RTPIEK53QZLE5EVBNHHBYD42OI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2916/review/286960400@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2916@github.com>
References: <quicwg/base-drafts/pull/2916@github.com>
Subject: Re: [quicwg/base-drafts] Move Generating Acknowledgements to Transport (#2916)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d7931de99a3e_4dfb3f841e4cd95c7587e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak32paKDRJzH+YZH1EkRtrZUBVhQBCD3Vzq8Oy hfhGawXh+TrIah9Zqv42Lg+BS45+NYglm1ws7tqzrMunG7eOkumDlLm18YWO4xNO5NZFSs5yO53HID SQFqRJ0eQvlubiqjeUrT4I0JxgSIbP7QMjgL8/LyEoPeSoGhZEMPVsKSsaehCQlVZsGVkJH2CbCDxa o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x66Y82LVw32tlkburMRRXKiRd9M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Sep 2019 17:41:53 -0000

martinthomson commented on this pull request.



>  ### Sending ACK Frames
 
-An endpoint sends ACK frames to acknowledge packets it has received and
-processed.
+An ACK frame SHOULD be sent immediately upon receipt of a second ack-eliciting
+packet. Loss detection does not assume that the peer sends an ACK immediately on
+receiving a second ack-eliciting packet.

@ianswett, not planning to do anything about this?  I'll merge it now if you think we should just leave this alone.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2916#discussion_r323372108

v2.23.0 | Report a Bug | By Email