IETF Logo Mail Archive

Re: [quicwg/base-drafts] When to send the SETTINGS frame (#2945)

Luca Niccolini <notifications@github.com> Thu, 01 August 2019 03:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7D07D120136 for <quic-issues@ietfa.amsl.com>; Wed, 31 Jul 2019 20:48:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T9ylk-ghTXeo for <quic-issues@ietfa.amsl.com>; Wed, 31 Jul 2019 20:48:13 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDA8A120137 for <quic-issues@ietf.org>; Wed, 31 Jul 2019 20:48:13 -0700 (PDT)
Date: Wed, 31 Jul 2019 20:48:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1564631292; bh=V8h+zl2bRQefi6GX97vtB6fyMlV+W3qDPUf/CMMbDjw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0K8ZbvNOMaPqabEZNkD6HyYnBlndq4Ul340q8DnAlsNB6VwJWtnA1C6e56vblwYqI a+yQy+L0Vw5vQFjaYmY/Ul6k46D6zXhxCFZKM4DFD7TKu784fW75mQWAERfz+x26rf XPXifku9zMtc+Vr2XUxVjja7wOdKwSe6aUW99mbM=
From: Luca Niccolini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYMUUGKXTFA4YMOME53J6JXZEVBNHHBYVUFKY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2945/517107263@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2945@github.com>
References: <quicwg/base-drafts/issues/2945@github.com>
Subject: Re: [quicwg/base-drafts] When to send the SETTINGS frame (#2945)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d4260fcb128b_7cdf3ff2bd0cd95c111081"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: lnicco
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yZuLu9AB5Jcf9xPSaJOLD3LU0ns>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Aug 2019 03:48:16 -0000

I agree with you and I vote for sending SETTINGS as soon as possible right after handshake. 

I want to warn you though that this does not prevent an implementor to chose something different since for how the protocol is designed -- after we removed waiting for receiving SETTINGS to send a request -- everything will keep working. As you said it would just be in a non-optimal state: i.e. without the ability to use the QPACK dynamic table and without GOAWAY. 

This is in fact something we never thoroughly test at interop since we only send a single request on a single stream and stop there.

As a sad/clowny story, we had a bug once where both endpoints would fail at reading from all unidirectional streams. It was so subtle that everything keep working fine, just no compression and no graceful shutdown.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2945#issuecomment-517107263

v2.23.0 | Report a Bug | By Email