Re: [tcpm] draft-gont-tcpm-tcp-seq-validation

Fernando Gont <fernando@gont.com.ar> Wed, 11 September 2013 21:04 UTC

Return-Path: <fernando@gont.com.ar>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BFA711E81BE for <tcpm@ietfa.amsl.com>; Wed, 11 Sep 2013 14:04:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bOMZ2M0qMlRr for <tcpm@ietfa.amsl.com>; Wed, 11 Sep 2013 14:04:32 -0700 (PDT)
Received: from web01.jbserver.net (web01.jbserver.net [IPv6:2a00:d10:2000:e::3]) by ietfa.amsl.com (Postfix) with ESMTP id AF62711E81B4 for <tcpm@ietf.org>; Wed, 11 Sep 2013 14:04:32 -0700 (PDT)
Received: from 202-175-17-190.fibertel.com.ar ([190.17.175.202] helo=[192.168.1.104]) by web01.jbserver.net with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.80.1) (envelope-from <fernando@gont.com.ar>) id 1VJraJ-0003q4-AF; Wed, 11 Sep 2013 23:04:24 +0200
Message-ID: <5230DAD2.2090506@gont.com.ar>
Date: Wed, 11 Sep 2013 18:04:18 -0300
From: Fernando Gont <fernando@gont.com.ar>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8
MIME-Version: 1.0
To: Rui Paulo <rpaulo@apple.com>
References: <CFDFBEFD-5C52-4DD2-B87F-ED94A0495CFE@apple.com>
In-Reply-To: <CFDFBEFD-5C52-4DD2-B87F-ED94A0495CFE@apple.com>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: tcpm-chairs@tools.ietf.org, Fernando Gont <fgont@si6networks.com>, tcpm@ietf.org, David Borman <David.Borman@quantum.com>
Subject: Re: [tcpm] draft-gont-tcpm-tcp-seq-validation
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tcpm>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Sep 2013 21:04:33 -0000

Hi, Rui,

Thanks so much for the review! Please find my comments inline...

On 09/11/2013 02:08 PM, Rui Paulo wrote:
> * Section 3.4 says " (Failed) Simultaneous Connection Termination" in
> the TCP time sequence ASCII

mm.. yes.. anything I'm missing?



> * Section 4.1.  TCP sequence number validation -> text is repeated

Yes. I guess the question here is what style we should use to do the update.

In other documents I authored in the past, I was asked to quote the text
to be replaced, and then the text it should be replaced with -- that's
why you see "duplicate" text.

Two possible improvements are:

* Indent the quoted text (although the indentation will mean that the
quoted text won't look the same as in RFC793, because the length of each
line would increase as a result of indentation, and hence they'd have to
be rewrapped), or,

* Try to quote only the specific sentences and tables to be replaced --
although this would make the text/spec harder to read.

Thoughts?



> * Section 7 doesn't look like an acknowledgement.

Yep. This will be fixed in the next rev.

Thanks!

Cheers,
-- 
Fernando Gont
e-mail: fernando@gont.com.ar || fgont@si6networks.com
PGP Fingerprint: 7809 84F5 322E 45C7 F1C9 3945 96EE A9EF D076 FFF1