Re: [Teas] I-D Action: draft-ietf-teas-yang-sr-te-topo-13.txt

[t petch <[e-mail]>]

An unrelated comment.

Looking at this again I thought this is nonsense.  Well, may be.  The 
layout is different to all the other YANG modules I know and that throws 
me, every time.

Go look at RFC8407 p.61 and it places grouping BEFORE the data 
definitions.  You mix them up which might have been a good idea but it 
is different to what everyone else does and that makes it a bad idea IMO.

I do not like grouping at the best of times but having them in the wrong 
place..

Tom Petch

p.s. -13 is an unlucky number in my culture, best avoided, so I was 
going to ignore that revision but this is a good chance to move quickly 
on to -14

On 22/03/2022 16:11, Xufeng Liu wrote:
> Hi Kenichi,
>
> Thanks for the feedback. We will do the updates as requested.
> Best,
> - Xufeng
>
> On Fri, Mar 18, 2022 at 10:00 PM Ogaki, Kenichi <[e-mail]> wrote:
>
>> Hi Xufeng,
>>
>> Thanks for reply.
>>
>> [Xufeng]:  S11~S53 are SR-enabled routers in the underlay topology. Do you
>> feel that the prefix is confusing? Do you think that a different prefix is
>> better, or the previous description statement is good enough?
>>
>> This is also editorial trivia, not technical one.
>> It's enough to just add an explanation for Sxx to the description
>> statement.
>>
>> Thank
>> Kenichi
>>
>>
>> Get Outlook for iOS <https://aka.ms/o0ukef>
>> ------------------------------
>> *From:* Xufeng Liu <[e-mail]>
>> *Sent:* Saturday, March 19, 2022 9:53 AM
>> *To:* 大垣 健一
>> *Cc:* [e-mail]
>> *Subject:* ***フリーメール*** Re: [Teas] I-D Action:
>> draft-ietf-teas-yang-sr-te-topo-13.txt
>>
>> Hi Kenichi,
>>
>> Thanks for checking on this and providing further comments
>> and suggestions. Will update the document to improve.
>> Best,
>> - Xufeng
>>
>> On Thu, Mar 3, 2022 at 11:06 PM Ogaki, Kenichi <[e-mail]> wrote:
>>
>>> Hi Authors,
>>>
>>> Thanks for accommodating our request.
>>>
>>> If only the links, 1-0-1, 1-2-1, 1-3-1, 2-1-1, 2-0-1 and 3-1-1, in Figure
>>> 4 are TE Enabled, it's friendly to touch on that in the 1st paragraph of
>>> B.2.
>>>
>> [Xufeng]: Yes. Will add some descriptions.
>>
>>>
>>> It's also better to explicitly describe what S11~S53 in Figure 5 means?
>>> (segment)
>>>
>> [Xufeng]:  S11~S53 are SR-enabled routers in the underlay topology. Do you
>> feel that the prefix is confusing? Do you think that a different prefix is
>> better, or the previous description statement is good enough?
>>
>>>
>>>
>>> Thanks,
>>> Kenichi
>>>
>>> Get Outlook for iOS <https://aka.ms/o0ukef>
>>> ------------------------------
>>> *From:* Teas <[e-mail]> on behalf of
>>> [e-mail] <[e-mail]>
>>> *Sent:* Wednesday, March 2, 2022 2:19:35 AM
>>> *To:* [e-mail] <[e-mail]>
>>> *Cc:* [e-mail] <[e-mail]>
>>> *Subject:* [Teas] I-D Action: draft-ietf-teas-yang-sr-te-topo-13.txt
>>>
>>>
>>> A New Internet-Draft is available from the on-line Internet-Drafts
>>> directories.
>>> This draft is a work item of the Traffic Engineering Architecture and
>>> Signaling WG of the IETF.
>>>
>>>          Title           : YANG Data Model for SR and SR TE Topologies on
>>> MPLS Data Plane
>>>          Authors         : Xufeng Liu
>>>                            Igor Bryskin
>>>                            Vishnu Pavan Beeram
>>>                            Tarek Saad
>>>                            Himanshu Shah
>>>                            Stephane Litkowski
>>>          Filename        : draft-ietf-teas-yang-sr-te-topo-13.txt
>>>          Pages           : 53
>>>          Date            : 2022-03-01
>>>
>>> Abstract:
>>>     This document defines a YANG data model for Segment Routing (SR)
>>>     topology and Segment Routing (SR) traffic engineering (TE) topology,
>>>     using MPLS data plane.
>>>
>>>
>>> The IETF datatracker status page for this draft is:
>>> https://datatracker.ietf.org/doc/draft-ietf-teas-yang-sr-te-topo/
>>>
>>> There is also an htmlized version available at:
>>> https://datatracker.ietf.org/doc/html/draft-ietf-teas-yang-sr-te-topo-13
>>>
>>> A diff from the previous version is available at:
>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-teas-yang-sr-te-topo-13
>>>
>>>
>>> Internet-Drafts are also available by rsync at rsync.ietf.org:
>>> :internet-drafts
>>>
>>>
>>> _______________________________________________
>>> Teas mailing list
>>> [e-mail]
>>> https://www.ietf.org/mailman/listinfo/teas
>>> _______________________________________________
>>> Teas mailing list
>>> [e-mail]
>>> https://www.ietf.org/mailman/listinfo/teas
>>>
>>
>>
>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon> Virus-free.
>> www.avast.com
>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>
>> <#m_-913408634061750565_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>
>
>
>
> _______________________________________________
> Teas mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/teas
>