Re: [xmpp] WGLC of draft-ietf-xmpp-websocket-02

Florian Zeitz <florob@babelmonkeys.de> Wed, 09 April 2014 19:48 UTC

Return-Path: <florob@babelmonkeys.de>
X-Original-To: xmpp@ietfa.amsl.com
Delivered-To: xmpp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 956D31A023D for <xmpp@ietfa.amsl.com>; Wed, 9 Apr 2014 12:48:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.878
X-Spam-Level:
X-Spam-Status: No, score=0.878 tagged_above=-999 required=5 tests=[BAYES_50=0.8, HELO_EQ_DE=0.35, RP_MATCHES_RCVD=-0.272] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UliNJ6vgeERs for <xmpp@ietfa.amsl.com>; Wed, 9 Apr 2014 12:48:46 -0700 (PDT)
Received: from babelmonkeys.de (babelmonkeys.de [IPv6:2a02:d40:3:1:10a1:5eff:fe52:509]) by ietfa.amsl.com (Postfix) with ESMTP id F24091A023B for <xmpp@ietf.org>; Wed, 9 Apr 2014 12:48:43 -0700 (PDT)
Received: from xdsl-87-79-63-110.netcologne.de ([87.79.63.110] helo=[192.168.0.140]) by babelmonkeys.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <florob@babelmonkeys.de>) id 1WXyUG-0002Jl-6g; Wed, 09 Apr 2014 21:48:44 +0200
Message-ID: <5345A413.6050205@babelmonkeys.de>
Date: Wed, 09 Apr 2014 21:48:35 +0200
From: Florian Zeitz <florob@babelmonkeys.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: xmpp@ietf.org
References: <F8275190-9346-4879-9843-A3DF6C604F8C@nostrum.com>
In-Reply-To: <F8275190-9346-4879-9843-A3DF6C604F8C@nostrum.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/xmpp/uv_uWnN2Z52gWaCT3gs2v8Cp3ms
Subject: Re: [xmpp] WGLC of draft-ietf-xmpp-websocket-02
X-BeenThere: xmpp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: XMPP Working Group <xmpp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xmpp>, <mailto:xmpp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/xmpp/>
List-Post: <mailto:xmpp@ietf.org>
List-Help: <mailto:xmpp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xmpp>, <mailto:xmpp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Apr 2014 19:48:51 -0000

I generally consider this draft to be in a decent shape. The wording and
general flow still seem a bit rough to me at times. More detailed
comments below:

= Substantive =
* Having some text explaining the general framing approach upfront
  would be helpful. This should note that an XML Stream is not used as
  described in RFC 6120, but <open/> and <close/> elements are used
  instead. The lack of a surrounding <stream:stream> element should
  be explicitly noted. This could go along with text explaining each
  message is a full XML document without an XML declaration.

3.5 Closing the connection:
 * "To initiate closing the WebSocket connection, the closing party MUST
   send a normal WebSocket close message with an empty body."
   Why? Having no body at all implies that sending a status code
   is not allowed. This seems undesirable to me.

3.5.1 see-other-uri
 * This currently says that the URI may only point to another WebSocket
   endpoint. IIRC the intent was specifically to be able to also move
   from WebSocket to BOSH.

= Editorial =
1. Introduction:
 * "The WebSocket protocol [...]. The WebSocket protocol [...]."

3.3 XMPP Stream Setup
 * It would be helpful to reuse RFC 6120's language here.
   I.e. "The first message sent by the initiating entity [...]"
   "The receiving entity MUST respond [...]"

3.6 Stanzas
 * "directly over the XMPP stream", RFC 6120 calls this a "XML Stream".
 * "XML text declaration" XML 1.0 calls this a "XML declaration",
   the whole sentence could use some rewording, possibly also mentioning
   size overhead.

3.7 Stream Restarts
 * "In these cases", only one case is listed. Possibly reword to say
   something like "Whenever a stream restart is mandated [...]"
   Clarify <open/> is used for stream restarts instead of
   <stream:stream>.

3.8 Stanzas
 * "that the XMPP stream is still alive" -> "XML Stream"

Regards,
Florian Zeitz


On 07.04.2014 23:29, Ben Campbell wrote:
> This is a Working Group Last Call of draft-ietf-xmpp-websocket-02. The draft is available at the following URL:
> 
> http://tools.ietf.org/html/draft-ietf-xmpp-websocket-02
> 
> The WGLC will conclude on 21 April, 2014. Please send your comments to the authors and the XMPP mailing list.
> 
> Thanks!
> 
> Ben.
>