Re: [bess] AD Review of draft-ietf-bess-evpn-overlay-08

Thomas Morin <thomas.morin@orange.com> Fri, 08 December 2017 09:45 UTC

Return-Path: <thomas.morin@orange.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F586126CBF; Fri, 8 Dec 2017 01:45:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.215
X-Spam-Level:
X-Spam-Status: No, score=0.215 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_BRBL_LASTEXT=1.449, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KFYwrn_iiH1b; Fri, 8 Dec 2017 01:45:37 -0800 (PST)
Received: from p-mail2.rd.orange.com (p-mail2.rd.orange.com [161.106.1.3]) by ietfa.amsl.com (Postfix) with ESMTP id 5C987126CB6; Fri, 8 Dec 2017 01:45:37 -0800 (PST)
Received: from p-mail2.rd.orange.com (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id B637DE300BA; Fri, 8 Dec 2017 10:45:36 +0100 (CET)
Received: from FTRDCH01.rd.francetelecom.fr (unknown [10.194.32.11]) by p-mail2.rd.orange.com (Postfix) with ESMTP id 9D21EE300B8; Fri, 8 Dec 2017 10:45:36 +0100 (CET)
Received: from l-fipglop (10.193.71.131) by FTRDCH01.rd.francetelecom.fr (10.194.32.11) with Microsoft SMTP Server id 14.3.361.1; Fri, 8 Dec 2017 10:45:35 +0100
Message-ID: <1512726336.28574.6.camel@orange.com>
From: Thomas Morin <thomas.morin@orange.com>
To: "Ali Sajassi (sajassi)" <sajassi@cisco.com>, Martin Vigoureux <martin.vigoureux@nokia.com>, Alvaro Retana <aretana.ietf@gmail.com>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>
CC: "bess@ietf.org" <bess@ietf.org>
Date: Fri, 8 Dec 2017 10:45:36 +0100
In-Reply-To: <109CAA9D-AA82-423E-8CEE-E721A1879D33@cisco.com>
References: <CAMMESsw2x53Av-_zi5nL5czKCXYmi_mk0i6qyYYZDYHE8oo_tA@mail.gmail.com> <3ca43a6b-2716-ff87-76da-ab520f23c6b4@nokia.com> <23037_1512483940_5A26AC64_23037_392_5_1512483939.26596.80.camel@orange.com> <109CAA9D-AA82-423E-8CEE-E721A1879D33@cisco.com>
Organization: Orange S.A.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.2-1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/GJ_ACzgRnKNqsQqsfzQVTrADGRE>
Subject: Re: [bess] AD Review of draft-ietf-bess-evpn-overlay-08
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Dec 2017 09:45:38 -0000

Ali,

A few nits, sorry for not answering earlier:
>   
> I added the following paragraph to section 6 for clarification:
> “When a PE advertises multiple supported encapsulations, it MUST
> advertise encapsulations that use the same EVPN procedures including
> procedures associated with split-horizon filtering described in
> section 8.3.1. For example, VxLAN and NvGRE (or MPLS and MPLS over
> GRE) encapsulations use the same EVPN procedures and thus a PE can
> advertise both of them and can support either of them or both of them
> simultaneously. However, a PE MUST NOT advertise VxLAN and MPLS 

You should say "VxLAN/NVGRE" here to be consistent with the rest of the
document that treats VXLAN and NVGRE equally.

> encapsulations together because a) MPLS field of EVPN routes is set 

- s/MPLS field/the MPLS field/
- "(a)" instead of "a)" would be a bit more readable

> to either a MPLS label for a VNI but not both and b) some of EVPN 

- s/a MPLS label/an MPLS label/
- s/for a VNI/or a VNI/
- s/some of EVPN/some EVPN/  (?)

> procedures (such as split-horizon filtering) are different for
> VxLAN/NvGRE and MPLS encapsulations.”

Thanks,

-Thomas