Re: [Gen-art] Gen-ART telechat review of draft-ietf-pwe3-iccp-stp-04
Jari Arkko <jari.arkko@piuha.net> Thu, 01 October 2015 12:25 UTC
Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 251111ACCF8; Thu, 1 Oct 2015 05:25:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F-fnvkUBiU8C; Thu, 1 Oct 2015 05:25:31 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id AB2C11AC3A5; Thu, 1 Oct 2015 05:25:30 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id C1C922CECD; Thu, 1 Oct 2015 15:25:29 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3rzmtV9kRB9j; Thu, 1 Oct 2015 15:25:29 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id EBA5C2CC6B; Thu, 1 Oct 2015 15:25:28 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_0BF8FE01-9632-47C8-8C78-237356432ABA"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5.1
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <CAA=duU0RNANMjvskewCQdWmbHv93siWeq3dbLHsEGyzuuiFR+g@mail.gmail.com>
Date: Thu, 01 Oct 2015 15:25:28 +0300
Message-Id: <48DE813A-5192-455E-AB17-DBB50A05EFF8@piuha.net>
References: <56049BBE.5090300@gmail.com> <CAA=duU2z2P-2jHMU-Basb4xKx=kuxEzA0f+UcuEDvthmB1tVwg@mail.gmail.com> <560C7A89.2020808@gmail.com> <CAA=duU0RNANMjvskewCQdWmbHv93siWeq3dbLHsEGyzuuiFR+g@mail.gmail.com>
To: "Andrew G. Malis" <agmalis@gmail.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/0SK52zxU6aGKU-a_L-8J-YoX5UM>
Cc: draft-ietf-pwe3-iccp-stp.all@ietf.org, General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART telechat review of draft-ietf-pwe3-iccp-stp-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2015 12:25:33 -0000
Thank you Brian for your review, and Andrew/authors for addressing the comments. Jari On 01 Oct 2015, at 03:34, Andrew G. Malis <agmalis@gmail.com> wrote: > Brian, > > Thanks, I'll ask the authors to add that. > > Cheers, > Andy > > On Wed, Sep 30, 2015 at 8:12 PM, Brian E Carpenter <brian.e.carpenter@gmail.com> wrote: > Andy, > > I think most people think of a spanning tree as being constructed over a > set of bridges, so I guess that in addition to the sentences you quote, > I would be happy to see a more conceptual description in the Introduction. > > "The spanning tree will be formed over [some set of nodes] without > the multi-homing links leading to loop formation. This is possible > because each redundancy group is treated as a single node for > spanning tree purposes." > > I'm sure this is blindingly obvious to y'all but not so much to someone > new to the topic. > > Regards > Brian > > On 01/10/2015 11:27, Andrew G. Malis wrote: > > Brian, > > > > On behalf of the authors, I would like to thank you for your review. Most > > of your points should be addressed as you recommend. > > > > I've just got a comment/question regarding your first major issue. > > > > Note that STP operationally is not impacted with the use of a RG. Section 2 > > says: “The link between the peering PEs is not visible to the bridge > > domains of the STP network. In this way, the STP will always break a > > possible loop within the multi-homed STP network by breaking the whole > > network into separate islands so that each is attached to one PE.” Other > > than that, operation is identical to the way VPLS works now, including the > > use of split-horizon to perform loop-breaking through the core. and that's > > also discussed in section 2. > > > > Does this satisfy your first comment? > > > > Thanks, > > Andy > > > > On Thu, Sep 24, 2015 at 8:56 PM, Brian E Carpenter < > > brian.e.carpenter@gmail.com> wrote: > > > >> I am the assigned Gen-ART reviewer for this draft. The General Area > >> Review Team (Gen-ART) reviews all IETF documents being processed > >> by the IESG for the IETF Chair. Please wait for direction from your > >> document shepherd or AD before posting a new version of the draft. > >> > >> For more information, please see the FAQ at > >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > >> > >> Document: draft-ietf-pwe3-iccp-stp-04.txt > >> Reviewer: Brian Carpenter > >> Review Date: 2015-09-25 > >> IETF LC End Date: 2015-09-23 > >> IESG Telechat date: 2015-10-01 > >> > >> Summary: Ready with issues > >> -------- > >> > >> Comments: > >> --------- > >> > >> The author responded helpfully to the following Last Call comments > >> but a new version is needed to fix them. > >> > >> It's impossible for a reviewer who is not expert in the details > >> of 802.1Q to check many details in this draft, so I didn't. > >> > >> Major Issues: > >> ------------- > >> > >> The draft does not properly explain the theory of operation. > >> The messages are defined but it is not explained when a spanning > >> tree is formed. Section 4 does not help with this. I think it > >> should be explained at the end of the Use Case section. > >> > >> The main normative reference appears to be IEEE 802.1Q-2005. The current > >> standard is IEEE 802.1Q-2014, which appears to be very different. > >> I think this should be discussed in the text to avoid confusion. > >> > >>> 3.6. STP Synchronization Data TLV > >> ... > >>> When the total size of the TLVs to be transmitted > >>> exceeds the maximal size of a fragment, these TLVs SHOULD be divided > >>> into multiple sets, delimited by multiple pairs of STP > >>> Synchronization Data TLVs, and filled into multiple fragments. > >> > >> There needs to be discussion of what happens if a fragment > >> is lost. > >> > >> Minor Issues: > >> ------------- > >> > >>> 3.2.1. STP Disconnect Cause sub-TLV > >> ... > >>> - Disconnect Cause String > >>> > >>> Variable length string specifying the reason for the disconnect, > >>> to be used for operational purposes. > >> > >> Should it be specified whether this is ASCII, UTF-8,...? > >> > >> Nits: > >> ----- > >> > >> Please expand Spanning Tree Protocol in the main title. > >> > >> Abbreviation PE used but not defined. Also, "provider edge" means an edge, > >> which is an abstract concept, not a device. If the draft is discussing > >> specific devices, it should say "PE device" or "PE router" or "PE switch". > >> > >> Abbreviation AC used but not defined. > >> > >> Abbreviation CE used but not defined. > >> > >> > > > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Gen-ART telechat review of draft-ietf-p… Brian E Carpenter
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Andrew G. Malis
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Brian E Carpenter
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Andrew G. Malis
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Jari Arkko
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Mingui Zhang