IETF Logo Mail Archive

Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Antoni Przygienda <prz@juniper.net> Mon, 08 August 2016 15:27 UTC

Return-Path: <prz@juniper.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B425D12D0BB for <gen-art@ietfa.amsl.com>; Mon, 8 Aug 2016 08:27:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.911
X-Spam-Level:
X-Spam-Status: No, score=-1.911 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=junipernetworks.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IIhAlYIZli5M for <gen-art@ietfa.amsl.com>; Mon, 8 Aug 2016 08:27:49 -0700 (PDT)
Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0113.outbound.protection.outlook.com [104.47.40.113]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DEF912B056 for <gen-art@ietf.org>; Mon, 8 Aug 2016 08:27:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=leGt5X+OsdKQ6+YGfQ/KHk+mtZGirgpO7sRXKJ9GqPY=; b=kfOOWXHfStXzhwMpkScSk3clLUK/q86iQ4CybbY9KyvA0oBhuAw6RlrIoK83x+OcWk5EaHW+GqfCB6+OwyhmiFv77ZZODzuFxodqa97Od3BkgCOyHaXY3DNMd66klJctmP23YOdvT7KzZZ9G668VWvoxZCcg++8UKRHzXEPepNA=
Received: from BN3PR0501MB1476.namprd05.prod.outlook.com (10.160.117.20) by BN3PR0501MB1474.namprd05.prod.outlook.com (10.160.117.18) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.8; Mon, 8 Aug 2016 15:27:46 +0000
Received: from BN3PR0501MB1476.namprd05.prod.outlook.com ([10.160.117.20]) by BN3PR0501MB1476.namprd05.prod.outlook.com ([10.160.117.20]) with mapi id 15.01.0557.009; Mon, 8 Aug 2016 15:27:46 +0000
From: Antoni Przygienda <prz@juniper.net>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-isis-remaining-lifetime.all@tools.ietf.org" <draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
Thread-Index: AdHwAkwUcT4hVHRjR9KTLedJakLzFgBd4LRg//+p4gA=
Date: Mon, 08 Aug 2016 15:27:45 +0000
Message-ID: <341F3450-96F5-4883-951E-73F81A6DD8E3@juniper.net>
References: <7594FB04B1934943A5C02806D1A2204B4BBB6B37@ESESSMB208.ericsson.se> <89d171e8f3b446eb99274208b6987993@XCH-ALN-001.cisco.com>
In-Reply-To: <89d171e8f3b446eb99274208b6987993@XCH-ALN-001.cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=prz@juniper.net;
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [66.129.239.12]
x-ms-office365-filtering-correlation-id: 62e3b409-c676-41a3-2ffa-08d3bfa08c68
x-microsoft-exchange-diagnostics: 1; BN3PR0501MB1474; 6:avZjHjCIcWHlcvncVN7XADLkEEZBv8Sy/DgyJDJ7CCJnBCeuvisLsqL4bkENSr6VCbHd/SAG+tQJZ4dcjHKTvzy+QMlXnWx2HqBUsnJ3QkPQYb85VzSadjdv/bNKszgEoHvwgudaoTpK9mQqDmqmMpTj/4oZ+Qe3kQScHPD64iSvPsQZTfAg3l0MJEn5/1viYDWJ17yVFiXrLST2bLW8MzbnfZg9oW/kl8/AGYJTLqHYP6uARpFnMxe+xkQ5EgXfspey9WeWMrgFqiWmpyQfXFY4UbAW+zjF8bUQB9epMzk5nuU+1TnqszH498UtXbEK7oX8IRZ48TLwigPVGCcsDQ==; 5:OJCUZO3WCW2vtDqMjJyt9WIFG3/h4oUzY4Hv1EOPDBu2Takd66S3DFXAHWsHdXYa+bFli4x4Q0M8t8N4/BbHQ5yEF0ccynmaszsab47L1TjXfL0+q01XvLquypD1+7IhVLHnatpQIDplE2H6jN0IOA==; 24:Qtl3xhmi8vk4uUF/Yhx1Rz1pb0fJW6jP2UH9uKWHeWds12C8m6pVDGY8wUYZnk07K0ByS0la2gNZYX9DtvJ+nLk1hZmOTGTfDbftj9eHdK8=; 7:NQb+CkeaPY76PZZs/xliIT4geiVR+Y88KkTg4/0mIEfcxqJNkapZZrstpLBBk6Ri2puRBkPKDDIsDjTkGbIMbCc9sHoJtJBt4x7izt457Sn5XE5Nc4LbJcXXbr9ANnyZ8cOEmE+YeZzQUF7jHXJGG+HQPyHCN31Mwp5BxfpYAiY2MtLQ7sQRrtIgulgxkLp+cMy6LdWSvaJS28XGYy+v8AbEDuBMAVPXBNseMjpaLp3V7wSg3ssBozkUPs9RB71L
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0501MB1474;
x-microsoft-antispam-prvs: <BN3PR0501MB14742B2D90FFBDAB75D41A87AC1B0@BN3PR0501MB1474.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(37575265505322)(95692535739014)(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:BN3PR0501MB1474; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0501MB1474;
x-forefront-prvs: 00286C0CA6
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(7916002)(199003)(189002)(377454003)(107886002)(77096005)(3280700002)(189998001)(3660700001)(99286002)(586003)(97736004)(15975445007)(105586002)(2501003)(2900100001)(16236675004)(68736007)(87936001)(36756003)(10400500002)(5002640100001)(2950100001)(11100500001)(5001770100001)(19625215002)(92566002)(76176999)(54356999)(33656002)(2201001)(86362001)(83716003)(82746002)(7846002)(19580395003)(230783001)(122556002)(81166006)(8676002)(81156014)(7736002)(7906003)(50986999)(8936002)(101416001)(6116002)(19300405004)(102836003)(19580405001)(106356001)(3846002)(19617315012)(66066001)(2906002)(104396002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR0501MB1474; H:BN3PR0501MB1476.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_341F345096F54883951E73F81A6DD8E3junipernet_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2016 15:27:45.9742 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0501MB1474
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/3PlsLxRIdaNLxjdJayh87qcM53o>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2016 15:27:51 -0000

+1 to what Les thinks …

--- tony


<ginsberg@cisco.com<mailto:ginsberg@cisco.com>> spake:

Christer –

Thanx for your review.

ISO 10589 is the base specification for IS-IS and there is a reference to it in the document.
This is where you will find details about Link State PDUs.

I would be reluctant to include any sort of summary description of an LSP in this document out of fear that it might be seen as differing from the base protocol specification.

I hope this addresses your concerns.

   Les


From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Saturday, August 06, 2016 10:03 AM
To: gen-art@ietf.org; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org
Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                       draft-ietf-isis-remaining-lifetime-02
Reviewer:                         Christer Holmberg
Review Date:                   6 August 2016
IETF LC End Date:            15 August 2016
IETF Telechat Date:        N/A

Summary:
The document is well written, and almost ready for publication as a standards track RFC, but I have a couple of editorial comments that I’d like the authors to address.
Major Issues:    None
Minor Issues:    None
Editorial Issues:
The Abstract says:
“Corruption of the Remainining Lifetime Field in a Link State PDU can go undetected.  In certain scenarios this may cause or exacerbate flooding storms.  It is also a possible denial of service attack vector.  This document defines a backwards compatible solution to this problem.”
…and the first sentence of the Problem Statement says:
“Each Link State PDU (LSP) includes a Remaining Lifetime field.”
I have no idea what a Link State PDU is, and there is no introduction to what the draft is all about. The text jumps direction into the work.
So, please add a reference to Link State PDU (LSP), and please give a little bit of introduction text what context/environment this is all about. I assume there is some core document which describes the context/environment where the Link State PDU is used?

v2.23.0 | Report a Bug | By Email