Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Christer Holmberg <christer.holmberg@ericsson.com> Mon, 08 August 2016 17:40 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAA8712D670 for <gen-art@ietfa.amsl.com>; Mon, 8 Aug 2016 10:40:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3pHXgFsAUJBb for <gen-art@ietfa.amsl.com>; Mon, 8 Aug 2016 10:40:29 -0700 (PDT)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19FA212D125 for <gen-art@ietf.org>; Mon, 8 Aug 2016 10:40:28 -0700 (PDT)
X-AuditID: c1b4fb25-ca31e98000001071-58-57a8c40bd8d9
Received: from ESESSHC016.ericsson.se (Unknown_Domain [153.88.183.66]) by (Symantec Mail Security) with SMTP id 61.E2.04209.B04C8A75; Mon, 8 Aug 2016 19:40:27 +0200 (CEST)
Received: from ESESSMB208.ericsson.se ([169.254.8.233]) by ESESSHC016.ericsson.se ([153.88.183.66]) with mapi id 14.03.0301.000; Mon, 8 Aug 2016 19:40:09 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-isis-remaining-lifetime.all@tools.ietf.org" <draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
Thread-Index: AQHR8XpFmk8icDJLjUeUNzKh9hnEBKA/UOFw///iIoCAACHP4A==
Date: Mon, 8 Aug 2016 17:40:08 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B4BBC35CF@ESESSMB208.ericsson.se>
References: <7594FB04B1934943A5C02806D1A2204B4BBB6B37@ESESSMB208.ericsson.se> <89d171e8f3b446eb99274208b6987993@XCH-ALN-001.cisco.com> <7594FB04B1934943A5C02806D1A2204B4BBC3533@ESESSMB208.ericsson.se> <8da3a59b3f2a4131b964101e773fb08d@XCH-ALN-001.cisco.com>
In-Reply-To: <8da3a59b3f2a4131b964101e773fb08d@XCH-ALN-001.cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.154]
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B4BBC35CFESESSMB208erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsUyM2K7ky73kRXhBj8mS1mc/XCF1eLqq88s Fhv+bGR3YPaY8nsjq8eSJT+ZPL5c/swWwBzFZZOSmpNZllqkb5fAlbF1M0dB63TGiqvXHjA2 MPa2MXYxcnJICJhIfFrbAmRzcQgJrGeUeDr7BTuEs5hRYuKzGcxdjBwcbAIWEt3/tEHiIgLn GCUOX7vABNItLOAisXDCYmYQW0TAVeLM491sELaTxJ5zDWAbWARUJOZeesIGModXwFdi+YIY iPntTBLnjy5iBanhBOqd/vorWC+jgJjE91NrwOYzC4hL3HoynwniUgGJJXvOM0PYohIvH/9j hbCVJBbd/gxVny+x78JZsDm8AoISJ2c+YZnAKDwLyahZSMpmISmDiOtILNj9iQ3C1pZYtvA1 M4x95sBjJmTxBYzsqxhFi1OLk3LTjYz1Uosyk4uL8/P08lJLNjEC4+rglt+qOxgvv3E8xCjA wajEw6tQvjxciDWxrLgy9xCjBAezkghv96EV4UK8KYmVValF+fFFpTmpxYcYpTlYlMR5/V8q hgsJpCeWpGanphakFsFkmTg4pRoYeVXWOLya5OLfU5lv+GzptQuvdcpKvigtnRnlb/npyLGG JX3e2Xt59yhs9zR6PW/Z9tfKP1/c5FpxrZyj9Kt33P1UvmWtV7YtPfCiXaTdhftYF+eXxDnf 1A7Pq+G/HZ4z6wL/pB95ahk1Avf/HvdYdOD2HK4fLe0czx726L1gieYIDLrNX76aTYmlOCPR UIu5qDgRAK3ZTMSnAgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/yUiPyEuAykrJJOXFMx4qWs7ojc8>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2016 17:40:35 -0000

That should work :)

Thanks!

Regards,

Christer

From: Les Ginsberg (ginsberg) [mailto:ginsberg@cisco.com]
Sent: 08 August 2016 20:39
To: Christer Holmberg <christer.holmberg@ericsson.com>; gen-art@ietf.org; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org
Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Christer -

I will place a reference in the Introduction - something like:

"[ISO10589} defines the format of a Link State PDU (LSP) which includes a Remaining Lifetime field..."

Hope that will suffice.

   Les


From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Monday, August 08, 2016 10:28 AM
To: Les Ginsberg (ginsberg); gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org<mailto:draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Hi,

>Thanx for your review.
>
>ISO 10589 is the base specification for IS-IS and there is a reference to it in the document.
>This is where you will find details about Link State PDUs.
>
>I would be reluctant to include any sort of summary description of an LSP in this document out of fear that it might be seen as differing from the base protocol specification.

I think it would be useful to place that reference also in the Abstract, and in the problem statement, before you start talking about the LSP.

You don't have to add an LSP description, simply a reference so that it is easy for me to know where to get more information - without having to look for the reference elsewhere in the document :)

Regards,

Christer


From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Saturday, August 06, 2016 10:03 AM
To: gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org<mailto:draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                       draft-ietf-isis-remaining-lifetime-02
Reviewer:                         Christer Holmberg
Review Date:                   6 August 2016
IETF LC End Date:            15 August 2016
IETF Telechat Date:        N/A

Summary:
The document is well written, and almost ready for publication as a standards track RFC, but I have a couple of editorial comments that I'd like the authors to address.
Major Issues:    None
Minor Issues:    None
Editorial Issues:
The Abstract says:
"Corruption of the Remainining Lifetime Field in a Link State PDU can go undetected.  In certain scenarios this may cause or exacerbate flooding storms.  It is also a possible denial of service attack vector.  This document defines a backwards compatible solution to this problem."
...and the first sentence of the Problem Statement says:
"Each Link State PDU (LSP) includes a Remaining Lifetime field."
I have no idea what a Link State PDU is, and there is no introduction to what the draft is all about. The text jumps direction into the work.
So, please add a reference to Link State PDU (LSP), and please give a little bit of introduction text what context/environment this is all about. I assume there is some core document which describes the context/environment where the Link State PDU is used?