Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Mon, 08 August 2016 17:39 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 276D812D670 for <gen-art@ietfa.amsl.com>; Mon, 8 Aug 2016 10:39:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.757
X-Spam-Level:
X-Spam-Status: No, score=-15.757 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.247, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X0goKqxRZwrn for <gen-art@ietfa.amsl.com>; Mon, 8 Aug 2016 10:39:19 -0700 (PDT)
Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1962A12D677 for <gen-art@ietf.org>; Mon, 8 Aug 2016 10:39:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=16411; q=dns/txt; s=iport; t=1470677959; x=1471887559; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=IpdazGa1qpLBiTy+a9j7Dahh+/Lelhh8i+ncIDwiYpQ=; b=asqgAdDsZvJ+5f1oWd3MZwyRN/JFzMm5AZ2nKCbpG3DQVDp8AGMQO/mU UMqw8uYSooaQYMw6bAPpG5xHaIy8G1Zj4wuJTOY0hy2K6JBsrMQodZ6Es ej0vTL2hRR/EveHqpgaM4VqI7pqpL4qBXJhGomATj6tyzyJ5itBL6TYrV U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ArAgBNw6hX/4QNJK1dgndOVnwHtAqFB?= =?us-ascii?q?4F9JIV5AoE/OBQBAQEBAQEBXSeEXgEBBS1cAgEIEQMBAQEoBzIUCQgBAQQBEgg?= =?us-ascii?q?TiBYOwnEBAQEBAQEBAQEBAQEBAQEBAQEBAQEchiqETYRgFoUlBZN1hUQBhhyIZ?= =?us-ascii?q?oFyToQNiH2MNIN3AQ8PNoN6bgGGX38BAQE?=
X-IronPort-AV: E=Sophos;i="5.28,491,1464652800"; d="scan'208,217";a="135571969"
Received: from alln-core-10.cisco.com ([173.36.13.132]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Aug 2016 17:39:02 +0000
Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by alln-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id u78Hd1R2019998 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 8 Aug 2016 17:39:01 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 8 Aug 2016 12:39:01 -0500
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1210.000; Mon, 8 Aug 2016 12:39:01 -0500
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-isis-remaining-lifetime.all@tools.ietf.org" <draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
Thread-Index: AdHwAkwUcT4hVHRjR9KTLedJakLzFgBd4LRgABKU+YAAClU0IA==
Date: Mon, 8 Aug 2016 17:39:01 +0000
Message-ID: <8da3a59b3f2a4131b964101e773fb08d@XCH-ALN-001.cisco.com>
References: <7594FB04B1934943A5C02806D1A2204B4BBB6B37@ESESSMB208.ericsson.se> <89d171e8f3b446eb99274208b6987993@XCH-ALN-001.cisco.com> <7594FB04B1934943A5C02806D1A2204B4BBC3533@ESESSMB208.ericsson.se>
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B4BBC3533@ESESSMB208.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.91.7]
Content-Type: multipart/alternative; boundary="_000_8da3a59b3f2a4131b964101e773fb08dXCHALN001ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zH2TD5hWlsV18mBNSAqhNlHHNec>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2016 17:39:28 -0000

Christer -

I will place a reference in the Introduction - something like:

"[ISO10589} defines the format of a Link State PDU (LSP) which includes a Remaining Lifetime field..."

Hope that will suffice.

   Les


From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Monday, August 08, 2016 10:28 AM
To: Les Ginsberg (ginsberg); gen-art@ietf.org; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org
Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Hi,

>Thanx for your review.
>
>ISO 10589 is the base specification for IS-IS and there is a reference to it in the document.
>This is where you will find details about Link State PDUs.
>
>I would be reluctant to include any sort of summary description of an LSP in this document out of fear that it might be seen as differing from the base protocol specification.

I think it would be useful to place that reference also in the Abstract, and in the problem statement, before you start talking about the LSP.

You don't have to add an LSP description, simply a reference so that it is easy for me to know where to get more information - without having to look for the reference elsewhere in the document :)

Regards,

Christer


From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Saturday, August 06, 2016 10:03 AM
To: gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org<mailto:draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                       draft-ietf-isis-remaining-lifetime-02
Reviewer:                         Christer Holmberg
Review Date:                   6 August 2016
IETF LC End Date:            15 August 2016
IETF Telechat Date:        N/A

Summary:
The document is well written, and almost ready for publication as a standards track RFC, but I have a couple of editorial comments that I'd like the authors to address.
Major Issues:    None
Minor Issues:    None
Editorial Issues:
The Abstract says:
"Corruption of the Remainining Lifetime Field in a Link State PDU can go undetected.  In certain scenarios this may cause or exacerbate flooding storms.  It is also a possible denial of service attack vector.  This document defines a backwards compatible solution to this problem."
...and the first sentence of the Problem Statement says:
"Each Link State PDU (LSP) includes a Remaining Lifetime field."
I have no idea what a Link State PDU is, and there is no introduction to what the draft is all about. The text jumps direction into the work.
So, please add a reference to Link State PDU (LSP), and please give a little bit of introduction text what context/environment this is all about. I assume there is some core document which describes the context/environment where the Link State PDU is used?