Re: [iola-conversion-tool] Bug when Adding a document to the tracker

Robert Sparks <rjsparks@nostrum.com> Wed, 22 February 2012 19:01 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: iola-conversion-tool@ietfa.amsl.com
Delivered-To: iola-conversion-tool@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8BFE121E8026 for <iola-conversion-tool@ietfa.amsl.com>; Wed, 22 Feb 2012 11:01:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[AWL=-0.000, BAYES_00=-2.599, HTML_MESSAGE=0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eZQBQqjsfY3N for <iola-conversion-tool@ietfa.amsl.com>; Wed, 22 Feb 2012 11:01:02 -0800 (PST)
Received: from nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id A550021E8028 for <iola-conversion-tool@ietf.org>; Wed, 22 Feb 2012 11:00:51 -0800 (PST)
Received: from dn3-177.estacado.net (vicuna-alt.estacado.net [75.53.54.121]) (authenticated bits=0) by nostrum.com (8.14.3/8.14.3) with ESMTP id q1MJ0mof097425 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 22 Feb 2012 13:00:50 -0600 (CST) (envelope-from rjsparks@nostrum.com)
Message-ID: <4F453B60.6010406@nostrum.com>
Date: Wed, 22 Feb 2012 13:00:48 -0600
From: Robert Sparks <rjsparks@nostrum.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1
MIME-Version: 1.0
To: Ole Laursen <olau@iola.dk>
References: <4F4415E7.9080608@nostrum.com> <CANb2OvKXRUarNY-Vp+CkA+7P5FZ1=_OfqyO67gOnKfx2bAARCQ@mail.gmail.com>
In-Reply-To: <CANb2OvKXRUarNY-Vp+CkA+7P5FZ1=_OfqyO67gOnKfx2bAARCQ@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------070009000308040105060409"
Received-SPF: pass (nostrum.com: 75.53.54.121 is authenticated by a trusted mechanism)
Cc: iola-conversion-tool@ietf.org
Subject: Re: [iola-conversion-tool] Bug when Adding a document to the tracker
X-BeenThere: iola-conversion-tool@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of the IOLA / DB Schema Conversion Tool Project <iola-conversion-tool.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/iola-conversion-tool>
List-Post: <mailto:iola-conversion-tool@ietf.org>
List-Help: <mailto:iola-conversion-tool-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Feb 2012 19:01:10 -0000

That's really surprising, and I want to double-check that we haven't 
accidentally lost something.

Your search was on the production code?

I'm seeing idinternal.area_acronym get used in trunk at
idindex/views.py: def all_id2_entry(id):
  ....
./idindex/views.py-    if id.idinternal:
./idindex/views.py-        try:
./idindex/views.py:            area = id.idinternal.area_acronym


and in the search form
/idrfc/views_search.py:            
q_objs.append(Q(area_acronym=query['area']))

What are those replaced with in the new code?

RjS

On 2/22/12 11:18 AM, Ole Laursen wrote:
> 2012/2/21 Robert Sparks <rjsparks@nostrum.com 
> <mailto:rjsparks@nostrum.com>>
>
>     The biggest is that the form didn't ask for the area the document
>     should be associated with.
>     It occasionally happens that an AD from outside the area takes the
>     shepherd role for a document, so
>     you can't infer this from which AD is assigned.
>
>
> Right. At the moment, we don't store an area at all. Grepping for it, 
> the only place I managed to find using the attribute apart from the 
> edit form is the agenda document template where the proxy wrapper will 
> infer the area from the WG (if there's a WG) or else from the 
> shepherding AD.
>
> The search page looks for the area of the WG in the old schema if you 
> do a search for area, not the area attribute which is perhaps not 
> surprising if it's only set for documents in the IESG process.
>
> So do you think this is a problem still?
>
>     Less important, (but important none the less), the fields are
>     initially populated very badly.
>
>
> That's odd. Or rather, it's odd that how it worked before because 
> AFAICT from the documentation to Django, it shouldn't have. :) It 
> could possibly be because of the new Django version. In any case, I 
> think I managed to fix this now.
>
> Ole