Re: [IPsec] Typos in draft-kivinen-ipsecme-ikev2-rfc5996bis-04

"Valery Smyslov" <svanru@gmail.com> Thu, 18 September 2014 13:55 UTC

Return-Path: <svanru@gmail.com>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 161EB1A87DF for <ipsec@ietfa.amsl.com>; Thu, 18 Sep 2014 06:55:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QEJxk96pnQB9 for <ipsec@ietfa.amsl.com>; Thu, 18 Sep 2014 06:55:30 -0700 (PDT)
Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com [IPv6:2a00:1450:4010:c04::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4EBBB1A87D4 for <ipsec@ietf.org>; Thu, 18 Sep 2014 06:55:30 -0700 (PDT)
Received: by mail-lb0-f173.google.com with SMTP id w7so1188505lbi.32 for <ipsec@ietf.org>; Thu, 18 Sep 2014 06:55:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:cc:references:subject:date:mime-version :content-type:content-transfer-encoding; bh=t1fOfRnigOsDK9UM1OmtY45c8gI/o/NOB7R2oe4L7HE=; b=0GanECXxMrRiT0cI8YTsHnK+z2x/2UHhoYdETFoIF2oXSMeSedpoG/yfAsvdnO5tuk qly6/cWqy46Vmiw/lTOtGe0nVCQ00XlHPJ5t4XvzJmawA5wBf1SkXznOlOrKmhs8AVN4 pXfFibx/iiZAvjc8+fM+7PYLylRhTct8qOGJBvkHtJWozZ7L4ryUCcee785WgUf24rMh Kk4Y5oIvJ5KE5g4fQHUwxzyWCHjb+x1qMepvorT4kMZvpIoqCLS0PLB9QlQBdXJj4iC8 WvgKVHfnrRcZS2K8ytiDiiVowwA5JuwVRa7NrzP588ocJnL0nXLcO6ZFtZu7zHqXM7Vs QB7w==
X-Received: by 10.153.11.132 with SMTP id ei4mr4902lad.24.1411048528563; Thu, 18 Sep 2014 06:55:28 -0700 (PDT)
Received: from buildpc ([93.188.44.200]) by mx.google.com with ESMTPSA id h6sm6273659lag.21.2014.09.18.06.55.27 for <multiple recipients> (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 18 Sep 2014 06:55:27 -0700 (PDT)
Message-ID: <EE25ACA922BC4A70852C7BD495162228@buildpc>
From: Valery Smyslov <svanru@gmail.com>
To: Paul Wouters <paul@nohats.ca>
References: <F68C660364DABE41AF4617F517EF548411707BE2@ESESSMB309.ericsson.se><21493.55390.157248.181030@fireball.kivinen.iki.fi><C949D5C9077942ACA31105FE4156154E@buildpc> <21504.31762.454252.961126@fireball.kivinen.iki.fi> <DC2FED9C253548E5875C4E5CCCFD40D0@buildpc> <4A81BADF09C04D50BFA83D59711A0EF7@buildpc> <EAFA100B50B24E0D81E9BCA44CAE9D94@buildpc> <alpine.LFD.2.10.1409180926200.1198@bofh.nohats.ca>
Date: Thu, 18 Sep 2014 17:56:01 +0400
MIME-Version: 1.0
Content-Type: text/plain; format="flowed"; charset="iso-8859-1"; reply-type="response"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Archived-At: http://mailarchive.ietf.org/arch/msg/ipsec/IzHMmDDfVG_qO0KBXiyj8_CNYMA
Cc: ipsec@ietf.org, Tero Kivinen <kivinen@iki.fi>
Subject: Re: [IPsec] Typos in draft-kivinen-ipsecme-ikev2-rfc5996bis-04
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Sep 2014 13:55:32 -0000

>> In Section 3.13.1 the description of the Selector Length field
>> doesn't mention that it is unsigned integer (as it is mentioned
>> for all other such fields).
>
> What's an unsigned integer? :P
> Do we mean octets? :)

Unsigned integer is an interpretation of this two-octets value
(presumably in network byte order). It is explicitely stated
for most multi-byte fields in the document. For example:

Section 3.11 (Delete Payload):

   o  Num of SPIs (2 octets, unsigned integer) - The number of SPIs
      contained in the Delete payload.  The size of each SPI is defined
      by the SPI Size field.

Compare with the Section 3.13.1, which I has complained about:

   o  Selector Length - Specifies the length of this Traffic Selector
      substructure including the header.

No indication of how "Selector Length" (it is 2 octets) should be treated.

OK, we all know how to interpret it (and we have interoperable 
implementations),
but it needs to be stated here, as it is stated for other such fields
in the document. I'm probably acting here as a perisher, but as
document is intended to become Internet Standard such nits need to be
removed, IMHO.

Regards,
Valery.

> Paul