Re: [IPsec] Typos in draft-kivinen-ipsecme-ikev2-rfc5996bis-04

"Valery Smyslov" <svanru@gmail.com> Fri, 05 September 2014 13:05 UTC

Return-Path: <svanru@gmail.com>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61D531A06B0 for <ipsec@ietfa.amsl.com>; Fri, 5 Sep 2014 06:05:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.139
X-Spam-Level: *
X-Spam-Status: No, score=1.139 tagged_above=-999 required=5 tests=[BAYES_50=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001, STOX_REPLY_TYPE=0.439] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id boJbxf2IMmYk for <ipsec@ietfa.amsl.com>; Fri, 5 Sep 2014 06:05:45 -0700 (PDT)
Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1F7411A016A for <ipsec@ietf.org>; Fri, 5 Sep 2014 06:05:44 -0700 (PDT)
Received: by mail-lb0-f174.google.com with SMTP id n15so3911498lbi.33 for <ipsec@ietf.org>; Fri, 05 Sep 2014 06:05:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:cc:references:subject:date:mime-version :content-type:content-transfer-encoding; bh=hKoHlGjunmfNO12IIyzPHC3N8sVED3t7fvc+EmguTBY=; b=mmIoYsOM9Mmj5Y/YE+a9nox/Gl7Cxf0VsROjBi5mUXzqpevdXX3qGsPZ/EzfneVEi2 TNufZdbWRIFQ4SYjxZquNeOSu4xN2oqGGQUytFe7AT2dLtsdn6teSZRr1XJkE5nUqKb5 bYRSSv8dECmmPVJim0YNT0nFywKXeWcngXE8I/vGkC3kOZBbhrRIm4RJrVID/RAMfGln PfCHZZ4BUU3oi8Hut24bWRNQcDssUnQILHZlR8azvboZHwDKk4T8Wk1POcz6e1AtYByV vkNUDK7iBys31InUmQpA9PWECrOIz45QxxUxxshmYqOQnAOoJmwLy98TC9Sd6VXs6q8w tSNA==
X-Received: by 10.152.28.230 with SMTP id e6mr11765056lah.62.1409922342091; Fri, 05 Sep 2014 06:05:42 -0700 (PDT)
Received: from buildpc ([93.188.44.200]) by mx.google.com with ESMTPSA id yx5sm716615lbb.35.2014.09.05.06.05.40 for <multiple recipients> (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 05 Sep 2014 06:05:41 -0700 (PDT)
Message-ID: <DC2FED9C253548E5875C4E5CCCFD40D0@buildpc>
From: Valery Smyslov <svanru@gmail.com>
To: Tero Kivinen <kivinen@iki.fi>
References: <F68C660364DABE41AF4617F517EF548411707BE2@ESESSMB309.ericsson.se><21493.55390.157248.181030@fireball.kivinen.iki.fi><C949D5C9077942ACA31105FE4156154E@buildpc> <21504.31762.454252.961126@fireball.kivinen.iki.fi>
Date: Fri, 05 Sep 2014 17:05:42 +0400
MIME-Version: 1.0
Content-Type: text/plain; format="flowed"; charset="iso-8859-1"; reply-type="original"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Archived-At: http://mailarchive.ietf.org/arch/msg/ipsec/S-m7cVngzL1MIA9XR6p_uggWI7E
Cc: ipsec@ietf.org
Subject: Re: [IPsec] Typos in draft-kivinen-ipsecme-ikev2-rfc5996bis-04
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Sep 2014 13:05:49 -0000

Section 2.23, 4th bullet:

   o  The recipient of either the NAT_DETECTION_SOURCE_IP or
      NAT_DETECTION_DESTINATION_IP notification MAY compare the supplied
      value to a SHA-1 hash of the SPIs, source or recipient IP address
      (respectively), address, and port, and if they don't match, it
      SHOULD enable NAT traversal.  [...]

It seems that there is an extra "address". Shouldn't it be:


   o  The recipient of either the NAT_DETECTION_SOURCE_IP or
      NAT_DETECTION_DESTINATION_IP notification MAY compare the supplied
      value to a SHA-1 hash of the SPIs, source or recipient IP address and 
port
      (respectively), and if they don't match, it
      SHOULD enable NAT traversal.  [...]

or

   o  The recipient of either the NAT_DETECTION_SOURCE_IP or
      NAT_DETECTION_DESTINATION_IP notification MAY compare the supplied
      value to a SHA-1 hash of the SPIs, source or recipient (respectively)
      IP address and port, and if they don't match, it
      SHOULD enable NAT traversal.  [...]