[IPsec] More nits in draft-kivinen-ipsecme-ikev2-rfc5996bis-04

"Valery Smyslov" <svanru@gmail.com> Tue, 23 September 2014 13:14 UTC

Return-Path: <svanru@gmail.com>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC1181A1AA7 for <ipsec@ietfa.amsl.com>; Tue, 23 Sep 2014 06:14:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.7
X-Spam-Level:
X-Spam-Status: No, score=0.7 tagged_above=-999 required=5 tests=[BAYES_50=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yeyCRcYAb7zS for <ipsec@ietfa.amsl.com>; Tue, 23 Sep 2014 06:14:45 -0700 (PDT)
Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com [IPv6:2a00:1450:4010:c04::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF6961A00A8 for <ipsec@ietf.org>; Tue, 23 Sep 2014 06:14:44 -0700 (PDT)
Received: by mail-lb0-f173.google.com with SMTP id 10so6897809lbg.18 for <ipsec@ietf.org>; Tue, 23 Sep 2014 06:14:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:cc:references:subject:date:mime-version :content-type:content-transfer-encoding; bh=eVOUSeqETrpxLiFCthV2zvvDwlU5P3Hx5evTa2w+6Yw=; b=yDijvQQ0TjEayvKyvvi8qA0ETWl3OF2rF97zfvPgacDTCzqhuio7MVafo66Nja/e7J 7ZxaMXyAWQSERINUkx1g5WNSWPK676hZPxW3R27zNODkP9IcDBcCIVOcx11Xp0JT1/3T FdoNUS++Sk8FLxWPvvyCfv8wXhsJ7+7FGobLZLDMWcT/hdLiciLmwcLCnrC0S/9VrYPZ g0sbrREggubz/4iYA9T6/d+/e/wKYd0ue1KIoem1GZReeu8Z5CNqReqOBerPO910KeE8 +t4MkEL34bOSCZxyMOUdNSw8uxbt3ioeY/Pa6TeAcqfZo5EaHHyPvV4BCji50xmqyQRw lZ3A==
X-Received: by 10.152.37.169 with SMTP id z9mr10254077laj.66.1411478083016; Tue, 23 Sep 2014 06:14:43 -0700 (PDT)
Received: from buildpc ([93.188.44.200]) by mx.google.com with ESMTPSA id jv4sm1687536lbc.35.2014.09.23.06.14.41 for <multiple recipients> (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 23 Sep 2014 06:14:42 -0700 (PDT)
Message-ID: <8139F5C1D4ED4E2181D40A58434ACE3A@buildpc>
From: Valery Smyslov <svanru@gmail.com>
To: Tero Kivinen <kivinen@iki.fi>
References: <F68C660364DABE41AF4617F517EF548411707BE2@ESESSMB309.ericsson.se><21493.55390.157248.181030@fireball.kivinen.iki.fi><C949D5C9077942ACA31105FE4156154E@buildpc> <21504.31762.454252.961126@fireball.kivinen.iki.fi> <DC2FED9C253548E5875C4E5CCCFD40D0@buildpc> <4A81BADF09C04D50BFA83D59711A0EF7@buildpc>
Date: Tue, 23 Sep 2014 17:14:50 +0400
MIME-Version: 1.0
Content-Type: text/plain; format="flowed"; charset="iso-8859-1"; reply-type="response"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Archived-At: http://mailarchive.ietf.org/arch/msg/ipsec/i7k56zz0kbIbEFds4h_5a-swG6g
Cc: ipsec@ietf.org
Subject: [IPsec] More nits in draft-kivinen-ipsecme-ikev2-rfc5996bis-04
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Sep 2014 13:14:46 -0000

1. Section 3.15.1:

   o  APPLICATION_VERSION - The version or application information of
      the IPsec host.  This is a string of printable ASCII characters
      that is NOT null terminated.

"NOT" is uppercase. Although it might be an intention to ephasise
the fact, that it is not null terminated, but it looks like RFC2119 word,
that is not the case.


2. Section 3.16:

   o  Type (1 octet) is present only if the Code field is Request (1) or
      Response (2).  For other codes, the EAP message length MUST be
      four octets and the Type and Type_Data fields MUST NOT be present.
      In a Request (1) message, Type indicates the data being requested.
      In a Response (2) message, Type MUST either be Nak or match the
      type of the data requested.  Note that since IKE passes an
      indication of initiator identity in the first message in the
      IKE_AUTH exchange, the responder SHOULD NOT send EAP Identity
      requests (type 1).  The initiator MAY, however, respond to such
      requests if it receives them.
...

   Note that since IKE passes an indication of initiator identity in the
   first message in the IKE_AUTH exchange, the responder should not send
   EAP Identity requests.  The initiator may, however, respond to such
   requests if it receives them.

The last para in the section is absolutely equal to the last two sentences
in the cited bullet, except that it doesn't use RFC2119 wording. 
I failed to see that it adds any value here.