Re: [IPsec] Typos in draft-kivinen-ipsecme-ikev2-rfc5996bis-04

[Paul Wouters <[e-mail]>]

On Thu, 18 Sep 2014, Valery Smyslov wrote:

>> What's an unsigned integer? :P
>> Do we mean octets? :)
>
> Unsigned integer is an interpretation of this two-octets value
> (presumably in network byte order). It is explicitely stated
> for most multi-byte fields in the document. For example:
>
> Section 3.11 (Delete Payload):
>
>  o  Num of SPIs (2 octets, unsigned integer) - The number of SPIs
>     contained in the Delete payload.  The size of each SPI is defined
>     by the SPI Size field.
>
> Compare with the Section 3.13.1, which I has complained about:
>
>  o  Selector Length - Specifies the length of this Traffic Selector
>     substructure including the header.
>
> No indication of how "Selector Length" (it is 2 octets) should be treated.
>
> OK, we all know how to interpret it (and we have interoperable 
> implementations),
> but it needs to be stated here, as it is stated for other such fields
> in the document. I'm probably acting here as a perisher, but as
> document is intended to become Internet Standard such nits need to be
> removed, IMHO.

Oh, I agree completely! Had I been able to pay more attention at the
time, I would have suggested never to mention "integers" or "(un)signed"
at all, and only mentioned octets. But we should make it all consistent
in the document, so thanks for catching that!

Paul