Re: [Isis-wg] draft-wei-isis-tlv-03 (Purge Originator Id)

Tony Li <tony.li@tony.li> Fri, 23 April 2010 23:51 UTC

Return-Path: <tony.li@tony.li>
X-Original-To: isis-wg@core3.amsl.com
Delivered-To: isis-wg@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 1782A3A68D1 for <isis-wg@core3.amsl.com>; Fri, 23 Apr 2010 16:51:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.401
X-Spam-Level:
X-Spam-Status: No, score=-1.401 tagged_above=-999 required=5 tests=[AWL=1.157, BAYES_00=-2.599, MIME_BASE64_BLANKS=0.041]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MMF2gJzSE5XM for <isis-wg@core3.amsl.com>; Fri, 23 Apr 2010 16:50:57 -0700 (PDT)
Received: from qmta11.emeryville.ca.mail.comcast.net (qmta11.emeryville.ca.mail.comcast.net [76.96.27.211]) by core3.amsl.com (Postfix) with ESMTP id 04E243A68C8 for <isis-wg@ietf.org>; Fri, 23 Apr 2010 16:50:55 -0700 (PDT)
Received: from omta08.emeryville.ca.mail.comcast.net ([76.96.30.12]) by qmta11.emeryville.ca.mail.comcast.net with comcast id 92JK1e0030FhH24ABBqmAx; Fri, 23 Apr 2010 23:50:46 +0000
Received: from [171.70.244.60] ([171.70.244.60]) by omta08.emeryville.ca.mail.comcast.net with comcast id 9BqK1e0091JuTAb8UBqRYD; Fri, 23 Apr 2010 23:50:44 +0000
User-Agent: Microsoft-Entourage/12.24.0.100205
Date: Fri, 23 Apr 2010 16:50:14 -0700
From: Tony Li <tony.li@tony.li>
To: Dave Katz <dkatz@juniper.net>, Les Ginsberg <ginsberg@cisco.com>
Message-ID: <C7F78048.D6F8%tony.li@tony.li>
Thread-Topic: [Isis-wg] draft-wei-isis-tlv-03 (Purge Originator Id)
Thread-Index: AcrjP7fT+vRGIMIl1USAoglQOWtY+A==
In-Reply-To: <A3D69F84-A3E7-4345-84B8-9A01DDE03185@juniper.net>
Mime-version: 1.0
Content-type: multipart/mixed; boundary="B_3354886241_1343239"
Cc: "bruno.decraene@orange-ftgroup.co" <bruno.decraene@orange-ftgroup.com>, weifang@chinamobile.com, lizhenqiang@chinamobile.com, isis-wg@ietf.org
Subject: Re: [Isis-wg] draft-wei-isis-tlv-03 (Purge Originator Id)
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/isis-wg>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2010 23:51:00 -0000

So I have aversion (perhaps irrational ;-) to overloading semantics into the
length field.  So I've actually added the flag.

I've also addressed a number of comments, both on list and privately, so
this is worth a full read.

Comments?

Tony



On 4/23/10 10:57 AM, "Dave Katz" <dkatz@juniper.net> wrote:

> This seems to make sense so long as the absence of the neighbor field
> unambiguously says that the inserting system is also the originator of the
> purge (otherwise you need a flag.)
> 
> --Dave
> 
> On Apr 22, 2010, at 2:39 PM, Les Ginsberg (ginsberg) wrote:
> 
>> One other suggestion.
>> 
>> The usefulness of the extensions defined in this draft depend upon the
>> extent to which they are deployed - which no doubt will take
>> considerable time under the best of circumstances. It seems that we
>> could enhance the usefulness of the extensions even in the case of
>> partial deployment by allowing an IS which supports these extensions to
>> add the new TLV to purges it receives that do not include the new TLV.
>> It could include both its own system ID (to identify who added the TLV)
>> and the system ID of the neighbor from whom the empty purge was
>> received. While this is not guaranteed to pinpoint the source of the
>> purge, it would at least provide a pointer to the portion of the network
>> in which the purge originated.
>> 
>> So the TLV would then look like:
>> 
>> TLV - code to be assigned by IANA
>> Length - Either (1 * systemid length) or (2 *system ID length)
>> Value -
>> System ID of the system inserting the TLV (Required)
>> System ID of the system from which the purge was received (Optional)
>> 
>> ???
>> 
>>   Les
>> 
>>> -----Original Message-----
>>> From: isis-wg-bounces@ietf.org [mailto:isis-wg-bounces@ietf.org] On
>>> Behalf Of Tony Li
>>> Sent: Wednesday, April 21, 2010 11:39 PM
>>> To: Les Ginsberg (ginsberg); lizhenqiang@chinamobile.com; Jie Dong;
>>> bruno.decraene@orange-ftgroup.co; isis-wg@ietf.org;
>>> weifang@chinamobile.com
>>> Subject: Re: [Isis-wg] draft-wei-isis-tlv-03 (Purge Originator Id)
>>> 
>>> 
>>> Hi Les,
>>> 
>>>> But hopefully we can comment on 01 anyway?? :-)
>>> 
>>> Of course!  ;-)
>>> 
>>>> I don't see the need for Section 3. It was interesting discussion
>>>> material while we were debating the merits of making this a WG
>>> document,
>>>> but I think it has drawbacks when it is included in what is intended
>>> to
>>>> become a standards document.
>>> 
>>> Well, the point was to help document some of the field failures that
>>> we've
>>> seen and motivate the changes.
>>> 
>>>> In the second set of three points, only the first (which documents
>>> the
>>>> lamentable purge on checksum error experience) has value. The last
>>> two
>>>> are anecdotal and could be translated as "there are some weird bugs
>>> out
>>>> there". Interesting - but unnecessary. The first point could be
>>>> mentioned in the introduction as part of the justification for the
>>>> protocol extensions - but I think even that is unnecessary.
>>> 
>>> True, but without the background, these changes would seem like
>>> something
>>> straight out of the Oort cloud.
>>> 
>>> Compromise: condense the text and move to the introduction?
>>> 
>>> 
>>>> In Section 5 I would like to see language which says "hostname TLV
>>>> SHOULD only be used in addition to the system ID TLV". As every IS
>>> MUST
>>>> have a unique systemID but hostnames are optional I would prefer
>> that
>>> if
>>>> an implementation chooses to include the extra info in the purge
>> that
>>>> the system ID ALWAYS be there. (This is unenforceable of course)
>>> 
>>> 
>>> Works for me.  Other folks?
>>> 
>>> 
>>>> I think there needs to be language which makes clear that the
>> absence
>>> or
>>>> presence of this additional information has no impact on the
>>> acceptance
>>>> of a purged LSP as valid i.e. no changes to the operation of the
>>> Update
>>>> process are introduced by this draft.
>>> 
>>> 
>>> Can't hurt.  I'm certain that this will break some conformance testers
>>> regardless.
>>> 
>>> Any other comments?
>>> 
>>> Tony
>>> 
>>> 
>>> _______________________________________________
>>> Isis-wg mailing list
>>> Isis-wg@ietf.org
>>> https://www.ietf.org/mailman/listinfo/isis-wg
>> _______________________________________________
>> Isis-wg mailing list
>> Isis-wg@ietf.org
>> https://www.ietf.org/mailman/listinfo/isis-wg
>> 
>