Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-15

Eliot Lear <lear@cisco.com> Mon, 22 January 2018 19:14 UTC

Return-Path: <lear@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84E4812700F for <netmod@ietfa.amsl.com>; Mon, 22 Jan 2018 11:14:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SDyau4tlXkZU for <netmod@ietfa.amsl.com>; Mon, 22 Jan 2018 11:14:14 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3501E126D45 for <netmod@ietf.org>; Mon, 22 Jan 2018 11:14:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=17000; q=dns/txt; s=iport; t=1516648453; x=1517858053; h=subject:to:references:from:message-id:date:mime-version: in-reply-to; bh=nlYu1EO+trTofw7IW/RQNIyViQ5SAIdUcVWiP+kxQI8=; b=UGkjV9XJekyFMOlxv2YxDee6XPCQFmJCIKo6hoY4nlHdq7BoFiIO1nPV fzclmb75JD/T/yIjR+qg0gNG6OUgdoOEzU/9takZkV7WbawJRUzJuorTk oWrBtyqa/nP37db/0i5AXCS7Jh2SqObsK7Hz1YDCowdLB57i5fiEjcJPF g=;
X-Files: ietf-pf.diffs, acl.diffs, signature.asc : 656, 2284, 488
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DAAQDSNmZa/xbLJq1dGQEBAQEBAQEBAQEBAQcBAQEBAYQodCeDXYsYj0EykWqFaYICBwMYAQqBOQGDD08ChUgUAQEBAQEBAQEBayiFJAEBBAEBIUsbCw4KKgICAiUwBgEMBgIBAYovELUAgicmihABAQEBAQEBAQEBAQEBAQEBAQEBAQEOCgWESYV9gwWDLwEBAoE8ARIBNhWCa4JlBaN6hF2CMY5NghuGH4Nxh3SXR4E8NiJgcDIaCBsVPYIqhFhAN4gtgjwBAQE
X-IronPort-AV: E=Sophos;i="5.46,397,1511827200"; d="asc'?scan'208,217";a="1539115"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2018 19:14:11 +0000
Received: from [10.61.198.231] ([10.61.198.231]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id w0MJEArd028397; Mon, 22 Jan 2018 19:14:10 GMT
To: Kent Watsen <kwatsen@juniper.net>, "netmod@ietf.org" <netmod@ietf.org>
References: <8C19AD4C-0DCA-4D96-A070-0D76BE92BFA4@juniper.net>
From: Eliot Lear <lear@cisco.com>
Message-ID: <1e5da232-82cd-5a1a-930e-555796bd2ef7@cisco.com>
Date: Mon, 22 Jan 2018 20:14:09 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <8C19AD4C-0DCA-4D96-A070-0D76BE92BFA4@juniper.net>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="8qmQ6caAFGo826vM0g4PnTRIo4dLisDNp"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/aCPIMh4fqLOkAip2P6aEVh_eZjw>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-15
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 19:14:16 -0000

Hi Kent and Mahesh and Sonal,

Thanks very much for working on this draft.  I have noted one problem
that I think needs correcting.  I come prepared with a diff.

The current model has {source,dest}-port-or-range hanging off ipv4 or
ipv6.  This is a transport parameter and is not appropriate for
protocols that do not use ports (ie, ICMP, ESP, etc).  A better locale
would be to hang these components underneath l4 underneath their
respective tcp and udp branches.

Because this is so basic a function, I propose that this *not* be
included in match-on-tcp or match-on-udp.  Instead, the contents of both
tcp and udp be moved to new containers "tcp-all" and "udp-all",
respectively, and the ports hang as peers to that.  Thus, if a very
simple device can understand TCP and UDP ports but cannot understand
more detailed information, that is supported.

 And so from a tree perspective, it would look like this:


       |        |  +--rw (l4)?
       |        |  |  +--:(tcp)
       |        |  |  |  +--rw tcp
       |        |  |  |     +--rw source-port-range-or-operator
       |        |  |  |     |  +--rw (port-range-or-operator)?
       |        |  |  |     |     +--:(range)
       |        |  |  |     |     |  +--rw lower-port    inet:port-number
       |        |  |  |     |     |  +--rw upper-port    inet:port-number
       |        |  |  |     |     +--:(operator)
       |        |  |  |     |        +--rw operator?     operator
       |        |  |  |     |        +--rw port          inet:port-number
       |        |  |  |     +--rw destination-port-range-or-operator
       |        |  |  |     |  +--rw (port-range-or-operator)?
       |        |  |  |     |     +--:(range)
       |        |  |  |     |     |  +--rw lower-port    inet:port-number
       |        |  |  |     |     |  +--rw upper-port    inet:port-number
       |        |  |  |     |     +--:(operator)
       |        |  |  |     |        +--rw operator?     operator
       |        |  |  |     |        +--rw port          inet:port-number
       |        |  |  |     +--rw tcp-all {match-on-tcp}?
       |        |  |  |        +--rw sequence-number?          uint32
       |        |  |  |        +--rw acknowledgement-number?   uint32
       |        |  |  |        +--rw data-offset?              uint8
       |        |  |  |        +--rw reserved?                 uint8
       |        |  |  |        +--rw flags?                    bits
       |        |  |  |        +--rw window-size?              uint16
       |        |  |  |        +--rw urgent-pointer?           uint16
       |        |  |  |        +--rw options?                  uint32
       |        |  |  +--:(udp)
       |        |  |  |  +--rw udp
       |        |  |  |     +--rw source-port-range-or-operator
       |        |  |  |     |  +--rw (port-range-or-operator)?
       |        |  |  |     |     +--:(range)
       |        |  |  |     |     |  +--rw lower-port    inet:port-number
       |        |  |  |     |     |  +--rw upper-port    inet:port-number
       |        |  |  |     |     +--:(operator)
       |        |  |  |     |        +--rw operator?     operator
       |        |  |  |     |        +--rw port          inet:port-number
       |        |  |  |     +--rw destination-port-range-or-operator
       |        |  |  |     |  +--rw (port-range-or-operator)?
       |        |  |  |     |     +--:(range)
       |        |  |  |     |     |  +--rw lower-port    inet:port-number
       |        |  |  |     |     |  +--rw upper-port    inet:port-number
       |        |  |  |     |     +--:(operator)
       |        |  |  |     |        +--rw operator?     operator
       |        |  |  |     |        +--rw port          inet:port-number
       |        |  |  |     +--rw udp-all {match-on-udp}?
       |        |  |  |        +--rw length?   uint16


A diff ietf-packet-fields.yang and ietf-access-control-lists.yang is
attached.

Eliot



On 17.01.18 22:55, Kent Watsen wrote:
> All,
>
> This starts a two-week working group last call on
> draft-ietf-netmod-acl-model-15.
>
> This working group last call ends on January 31st.
> Please send your comments to the NETMOD mailing list.
>
> Positive comments, e.g., "I've reviewed this document
> and believe it is ready for publication", are welcome!
> This is useful and important, even from authors.
>
> Also, could the authors, explicitly CC-ed on this email,
> please confirm at this time that they are unaware of
> any IPR related to this draft.
>
> Thank you,
> NETMOD Chairs
>
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod
>