Re: [nfsv4] draft-ietf-nfsv4-umask

spencer shepler <spencer.shepler@gmail.com> Thu, 24 August 2017 06:29 UTC

Return-Path: <spencer.shepler@gmail.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8045126E64 for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 23:29:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nn8CgE9kZmST for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 23:28:59 -0700 (PDT)
Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9A9D132334 for <nfsv4@ietf.org>; Wed, 23 Aug 2017 23:28:58 -0700 (PDT)
Received: by mail-oi0-x234.google.com with SMTP id r200so21427266oie.2 for <nfsv4@ietf.org>; Wed, 23 Aug 2017 23:28:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=b4nJlnbkEY4mz1yzStOyf49C9dApsGZAnzNN0QzASaI=; b=mPK5og6u/KsSt3QyiLShG07H0S8U+eD4qV6ktO7ligJJFlISxvt4Klp9hX9ZbwbfMv jxQ1ZU0puYZK5r21o4LQVEFtCldidYl5H5s71z8GoanPKv4d3cJX4GT8bNRAYZPt7TVy kg+7AbxEq+labB6FK2KYN3FYy2Vn7z6l9fmruNACLFwLrytkWpgpEEg411U1vNyTL89v H4lENBmOYPzvlp4VzPvxri0F9k6SbZzGX1DCHTbAHDsCXX0mBfJIYunevVIfsx1/0All 6QQnkafGH/VUz15FbMAO+2zUaBfsP4dJ5kPNgrVfx6da0+uh0TYTFHHuhcu5JwaoP3SK XktA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=b4nJlnbkEY4mz1yzStOyf49C9dApsGZAnzNN0QzASaI=; b=qXNVMaKkY+rYHCMK59G3VwhUoyzRONYZfuQCMIEfNQzXnNMSGQbpIybVdfWjorZOvT 6tOe7cJ/0ajR9FnDUQ3H5Q7aobLzfuDI1vfUCaKshOJBR/gVrmf05Gm3rOBzgDOXu195 la+1q0pcv9Mdmq1+CUk3tyWbqWXbWm9njWoMCz88T4l8u+GAV11s787gNzevzvbwODKN 6DVhd83iRIQparw80LSM6VWzzZeEMgIKpyl5lzjbWQ5Lgr0q52T1yH/J9QJpwgd1XppQ Ca26B0QqgU75ZPcjiFf8ccEQFYNTzdr1FEOQ/LFTmQYD8UqTei/YEX2aQ0XsHaqdcBNH t68g==
X-Gm-Message-State: AHYfb5hUFR0qVqhUFt8I0Egm59BY5FJCvjgNJsxOktQx5H0YBTEKqS1B XM9ct5/fyjd5JNLR6uKpKRxzmHQEhA==
X-Received: by 10.202.207.135 with SMTP id f129mr6415920oig.232.1503556138263; Wed, 23 Aug 2017 23:28:58 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.74.137.213 with HTTP; Wed, 23 Aug 2017 23:28:57 -0700 (PDT)
In-Reply-To: <CADaq8jd51=2fU=jzi-f17E5Yr-0ZJ461uuXC33Ff90YoCsQtDw@mail.gmail.com>
References: <CCE6471D-5252-4313-BDED-5EAA468E3FAA@primarydata.com> <20170823155536.GA10035@fieldses.org> <CAFt6Ba=Ab=TLURRJ9ULdmU_8FydkeijfoHpgzd1bBTtx6YcBHQ@mail.gmail.com> <7824C7CB-FA68-4BC8-BF92-F93B37521B91@primarydata.com> <CADaq8jd51=2fU=jzi-f17E5Yr-0ZJ461uuXC33Ff90YoCsQtDw@mail.gmail.com>
From: spencer shepler <spencer.shepler@gmail.com>
Date: Wed, 23 Aug 2017 23:28:57 -0700
Message-ID: <CAFt6BamfwnsEBeMf5ad2KAn=Xk+Mrs9bRT0-JQ=8Zp8D-CkmXw@mail.gmail.com>
To: David Noveck <davenoveck@gmail.com>
Cc: Thomas Haynes <loghyr@primarydata.com>, "J. Bruce Fields" <bfields@fieldses.org>, "nfsv4@ietf.org" <nfsv4@ietf.org>
Content-Type: multipart/alternative; boundary="001a113adec8856b8b055779f175"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/eiIywxYQ8E4lxzpwu__MS3_slcA>
Subject: Re: [nfsv4] draft-ietf-nfsv4-umask
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Aug 2017 06:29:03 -0000

On Wed, Aug 23, 2017 at 6:53 PM, David Noveck <davenoveck@gmail.com> wrote:

> > We need to close on this (if there is going to be a change or not)..
>
> We certainly do.
>
> I'm kind of unsure about how a decision will be made.
>
> I suppose some people will comment and then Spencer will wrestle with the
> subtleties of the concept of consensus.
>

Consensus has been met IMO.  Tom raised the issue, Bruce responded, I asked
if Tom would be okay without making the change, he said he was "fine
without making the change".


>
> I hope it will be a help to the proocess but my opinion is that Tom' s
> requests are reasonable and the requested changes should be made.  I think
> I raised these issues during WGLC but didn't bother to press the matter at
> that time.  Unlike Tom, I would not be OK if this change is not made, but I
> don't want to make a big deal about it.   I guess we need to  hear from
> Bruce with a clear statement about his willingness to make the requested
> changes.  Bruce appears reluctant (so far) to make these changes but he has
> not actually refused.
>

If you like to suggest a change, Dave, then please do so directly.  It is
unclear with the above text your position since you state "I don't want to
make a big deal about it" and "but he has not actually refused".

As mentioned, I consider the issue closed and we can move forward.  Please
clarify.


>
> > This document is technically in AUTH48 period
>
> Actually, it has not yet started RFC editing.  For some reason it is stuck
> in MISSREF.  It shouldn't be because it is waiting for RFC 8178 which was
> published in July.
>

Looks like the editor needs a nudge as to the MISSREF - I will check into
that.


>
> >we can make the changes but need to know what they are and hear any
> objections
>
> I think Tom's request was pretty clear.
>
> I haven't heard any objections, unless you count Bruce's remarks, which
> are ambiguous.  It is a question of how long we are willing to wait, but
> even if there are no objections, the real question is whether Bruce is
> willing to make the requested changes.  I think these changes will only be
> made if Bruce is willing to make them.
>

As mentioned, I am clear so if there is is concern with my position -
suggest modified text or assert support for Tom's modifications clearly and
we will go from there and reopen the issue.


>
>
>  > (as has been queried for Manoj's changes).
>
> There the changes have alreay been made and the question is how long we
> are willing to wait for objections which are unlikely to arive.
>
> How about 48 hours?  i.e. if there are no objections by 3:00 UTC on 8/26,
> the changes are to be considered to be approved.  OK?
>

No.  Thanks for pointing out that I did not provide a deadline for
feedback.  Given summer vacations, etc. I will ask for feedback by next
Wednesday and will post this to the original thread.

Spencer


>
> On Wed, Aug 23, 2017 at 7:46 PM, Thomas Haynes <loghyr@primarydata.com>
> wrote:
>
>>
>> On Aug 23, 2017, at 4:24 PM, spencer shepler <spencer.shepler@gmail.com>
>> wrote:
>>
>>
>> We need to close on this (if there is going to be a change or not).. This
>> document is technically in AUTH48 period - we can make the changes but need
>> to know what they are and hear any objections (as has been queried for
>> Manoj's changes).
>>
>> Tom?
>>
>>
>> While I would like it cleaner, I am fine without making a change.
>>
>>
>>
>> Spencer
>>
>> On Wed, Aug 23, 2017 at 8:55 AM, J. Bruce Fields <bfields@fieldses.org>
>> wrote:
>>
>>> On Tue, Aug 22, 2017 at 08:36:38PM +0000, Thomas Haynes wrote:
>>> > Hi Bruce,
>>> >
>>> > Can you modify your draft such that it generates xdr?
>>>
>>> I considered that but it seemed like a lot of boilerplate for little
>>> return.  The code to extract the xdr might almost be longer than the xdr
>>> you're extracting.  I dunno.
>>>
>>> >
>>> > I.e., I went to add a new const for your new attribute, and unlike the
>>> xattr document, I had to guess:
>>>
>>> You didn't have to guess the number, just the constant name, right?  I'm
>>> not sure how much that matters.
>>>
>>> --b.
>>>
>>> > %/*
>>> > % * New For UMASK
>>> > % */
>>> > const FATTR4_MODE_UMASK         = 81;
>>> >
>>> > Iā€™d recommend that you add the ā€˜///ā€˜.
>>> >
>>> > Also, you should use the <CODE BEGINS> and <CODE ENDS> at the very
>>> least here:
>>> >
>>> > 4.  mode_umask Attribute
>>> >
>>> >
>>> >          struct mode_umask4 {
>>> >            mode4  mu_mode;
>>> >            mode4  mu_umask;
>>> >          };
>>>
>>> _______________________________________________
>>> nfsv4 mailing list
>>> nfsv4@ietf.org
>>> https://www.ietf.org/mailman/listinfo/nfsv4
>>>
>>
>>
>>
>> _______________________________________________
>> nfsv4 mailing list
>> nfsv4@ietf.org
>> https://www.ietf.org/mailman/listinfo/nfsv4
>>
>>
>