Re: [Ntp] Éric Vyncke's No Objection on draft-ietf-ntp-mode-6-cmds-09: (with COMMENT)

Brian Haberman <brian@innovationslab.net> Mon, 24 August 2020 13:27 UTC

Return-Path: <brian@innovationslab.net>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B04DC3A0DD6 for <ntp@ietfa.amsl.com>; Mon, 24 Aug 2020 06:27:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.945
X-Spam-Level:
X-Spam-Status: No, score=-0.945 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-0.948, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=innovationslab-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hdkgD200gt3w for <ntp@ietfa.amsl.com>; Mon, 24 Aug 2020 06:27:38 -0700 (PDT)
Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B13D3A0DD2 for <ntp@ietf.org>; Mon, 24 Aug 2020 06:27:38 -0700 (PDT)
Received: by mail-qk1-x72c.google.com with SMTP id u3so7306361qkd.9 for <ntp@ietf.org>; Mon, 24 Aug 2020 06:27:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innovationslab-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KsgGLi6KqepR8a6urmFA5uRROQm7MI8lCdeNfLK40Es=; b=LrOvZ1D/aBP5NJIq68tXiX5DCVv/mt+hluuXreV80ZL1GFDPNscpJ4oh2CeLgwd2YH M3NzwdfirLRdEBG0D4euNBmKf5fjooEeHCtt1yecrd9MjHlfsLoJWLU6LopGB4uzMn90 3GzBedLyxK7FFKxPMEvhUbUa78rqRSFY0rXTw4UugBCttCf5nIPSZ9fFX5PIsCHQnbcK BCKz2v++Anl1XRLO8O/tyRVTTZxPixneYlxxTTgRlGFNAuA7TltgVnjZoNEwPRdIPqOA OAFMv2MBPOshmLv63Q0E0xrI4fW5OBSvc2EHmarkwsvylGyQPQpLE6K3i+X/3B1YFMBv e1ZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KsgGLi6KqepR8a6urmFA5uRROQm7MI8lCdeNfLK40Es=; b=fZoeT1CqXsxUDU/QkojNcOQ0OqXlDwK9rbloYhKmjnDQ3ph4cmiC0D05vcDoS1euFh YEh/rRbaNgebocXUOrlDac5f6iZzpE7gbIQNwQu82L1jbNuJYO5vC3zQ/SjI2cmbUuNa yCovSkVeHd7Tjqrt6h0iQQjfHnvErTHJeitvKjsx5AeQuAMDerbgmWSZvh9wjRG2LtAo CVUGxv8UO2lEQw0xSAY6/MLL8+be2AV3jf+urtwVyRteYJAmNV+NvSI5xBuYvP8vWzmJ +H+sZfVEbByjnOqCxBWr1zUqr9hOFJAlIg52YvSXuxra/zP4MVWHNUl3OZ2IkdxMDLsN RSvg==
X-Gm-Message-State: AOAM531kMF9p2sUC+dnYQ3ADWGELccdb8EW0rDN6tRReCz2NgQoWk9Ce VSci4aQxOpky+WESLmSFSwlPNw==
X-Google-Smtp-Source: ABdhPJyx3a3j6K8gZp83POgCzQmN0PE2bYNQyWEg8kkWhLLVLTxBctskhHfrF1IN8v7fRI9Nf/EeHw==
X-Received: by 2002:a37:a54:: with SMTP id 81mr4682149qkk.358.1598275656718; Mon, 24 Aug 2020 06:27:36 -0700 (PDT)
Received: from LakeHartwell.local ([2601:154:c001:f99e:c9dc:45bf:24ef:2791]) by smtp.gmail.com with ESMTPSA id n200sm3790076qkn.130.2020.08.24.06.27.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 06:27:35 -0700 (PDT)
To: Harlan Stenn <stenn@nwtime.org>, "Eric Vyncke (evyncke)" <evyncke=40cisco.com@dmarc.ietf.org>
Cc: The IESG <iesg@ietf.org>, "ntp-chairs@ietf.org" <ntp-chairs@ietf.org>, "ntp@ietf.org" <ntp@ietf.org>, "draft-ietf-ntp-mode-6-cmds@ietf.org" <draft-ietf-ntp-mode-6-cmds@ietf.org>, Karen O'Donoghue <odonoghue@isoc.org>
References: <15050B28-34A0-4474-A594-F5CA334B5EFE@cisco.com> <9712A8B7-C516-499C-BE3E-2CEC19D9B0CB@nwtime.org>
From: Brian Haberman <brian@innovationslab.net>
Autocrypt: addr=brian@innovationslab.net; keydata= mQINBFm5KgYBEACs2icafejrG19L5DRNFq8Q2O+K+LRxjR4qAElZDnXFXNA2ipFWPeT0J2wa KJ+h9UdfhDm8DzULB553CYm+Q3XF1N56TglkIRMZYc7mYXZEr3x7e4fmX4kD4qMjBLG8cL26 rEe3Q0qaiMGY69/4o5coVMT0qmHjgCH1tkG+L2Y8MKr1gFxS18eO8MVoWe1yDKuyxFSElHGB 3mZn4gcqeCaemPGG3CiVNlp4KnijpNcSgvseXbkQEA4IXEsIvUL8MIwOTXg9Gh5cbtisZpuf +4B0LNMUSqWlqyKd9M3KCMj+dW4vsFytc00Z+GyQ+ArOR9GwTdAwJ5qqVODTvbjKqOR1zolJ 1JxLUtSiv7Lx5x2OrCexPYXkzlTkjG9Imtg2XNh55R/JKMC3KU1NQL3nS9tJXeoRWNgWSZrG MsrbeejbqLVb9LblXNpgLciJ96XHMvYAXX7p4LAwivzSRrVg46vErYIAV6EvDvwVENWW8JCU 0vX5iTGfkEwU4KxCa7WAmmD8yiNspHP1J0uk93Sta5K0PuTi7b+EZlCjdrqOEWLGPv6qXlIu FwLLcCaDs3XdVvwgNM+UFRxFH1aOVQQKCiCOCcNlwgYG1u4ZbD2T6hd/d2tOAKu/MNnQVF7d Cfi2BtSjzglLcY61e37zqTM04BgU+LniZ7V99yneM6DM2UzgkwARAQABtClCcmlhbiBIYWJl cm1hbiA8YnJpYW5AaW5ub3ZhdGlvbnNsYWIubmV0PokCQAQTAQoAKgIbAwUJB4YfgAULCQgH AwUVCgkICwUWAgMBAAIeAQIXgAUCWbkqSAIZAQAKCRBo1jycU9GLYQixD/9UX0uiAvbJ+4dK z3Ne3kUdDK0Lk73RGfFgE/ezsc9I6ED82h+arC8pAoDnBWgzTxugZdbexek983bgMq02XFsG pJf7hudeKnB8UmtjTc0j1UUgi129FYyBmINS2Lz1gpEOygFfbeOGLJK5qZJwD3I3O6yN8SUZ uwahXXd1aEB+d1eGhNqxkjQ+L7vdfTlN662GWog3ROMwUbrg0+QAbn/Vlp2iIYO6VERUZ9Yr GfFJX9b9LKa6AHxzAaqFIix1h2wBiIacpIBGU/4+3+wL5zkCbGSRzoIHW8srllj7ehgwwfNx QevibuZWJ4XpHpIxrtsmBO7ERFk8pN7oiQ9M3b2Cg9OBD5vgxyMCHEKIblWyKz8GLtz5357L ORU1EBWB8BoJPBHz3u7bZE+jH9+w5PpI087Ae78KCDkTNj7o2wbkRoYLmLpMo8DOwAumyy5R 2DuRu0cn5Rw5pFjlJkyfM0Wf80Ml/SINrUORWeqSbsHSX8i+Y0Oyt5JNo9NFbgN0Gn/Qo364 I8cLgbvUAyFHwhnmbHB+QXFCGAy73NOQ+g2fCRPeSbihhYa34ugfmd4oa6W2w805ixzM7iGr P+wDB1dhA7eHKVmoo9Kxvm9VzU+2homYGEROd/H6n0BMvWtp1oFh/JvEgZN6dVLg3p+XX5Zj Ggy568bIY4P5kP7pAxh017kCDQRZuSoGARAAtCWxW1cRne/iGbFuibvB8d3upcbCB7oz4LWk LSE20Db2ymn04ici9V+wBSWX57me5jQdwMi/gzVVZcupbzWTg5Yhv7Qt7CKORJLEKo6nULbb 4aEpdOXD9s7wwx+foFjzjtDOH/JYoB+OEe2oW39VmK6EsIx7ClsLf6+cih5yApZHtmV+2M3J YSxD2kCUE619ITFLAkMf203ap5vJ6DDaaKnVoNhF9qV7jlJEceGqHTBG4KkBX/zNCehMIfhr ViY/B2IWAHeuZ99lnCPx2mehGGa4XLjQauUkY9KB7dOq/ODyt+7SL0dfWrOVf3BnU3C308b4 9YdId8KI4dJ30nfXn6ifTK9STZHZE+Mt1sIVmtEguqMXEk/axZmT14x194c7ZPmU/uCQTE3U y1NFs4Yof50WF1ze0CyN2ycmqx11mHjP5+L23TqcdIWmJG+EtdHUAFpu42kbB0fML3Oc/cEU SmWK3WpF5YPljLM2gyh3RXjuiBnaGoJaKTOj5zXQ2G2l3/ijbn9FbqmFup+R352dxUyakXEP xNe3HdyjfyUcy/RJNeZz/lgUIhkxWQjOOU1RIN41RtCKcF9tJjMwgQvI51QmPvf90/6ab3I/ vwEpjlRb4AbuWfPWe89J+Z3TG97V9sntlMcQ6MGiPLbyFpiXIf2150e6FxZdJtipVwY2d/kA EQEAAYkCJQQYAQoADwUCWbkqBgIbDAUJB4YfgAAKCRBo1jycU9GLYfy0EACYrxb4nWtOnIu0 N7rXXo/0ZjaBTyUhJ6hzy2D7rt3vv/qj2ui+N21ui/yMDS928za/XRfP25qN9A1puioHqN4l SAsxwCC3mT9GJXVXVgivg3MeciqBXoOdnk1hUkP1CTKL3qZ9pSuw8bPlNE7+b1xF7Oce37YH +QRVmBXbGwTxtDTCZ9Js0/IpiUtg9QCfmryB1r/fD0TFb8b9aCBuVeKocWSuX9UXRt7zRGM8 BJwOLvdLdGvV8us1imlBKFLai4L8CPgihuc/s7ZB0r3pgW697hXScWhGHF3OUWbPFVkNyivM xtDcq+9ZlUMrxFbwUEABi8NFwvzwn+YJQqlrPiF4xxsScYpnIlfWEuP6Vpp6Z/u5x+1MNyZb oxNWWaevMVeo3tdRV9F6/YFqucw4JQ9HqlCKQ62sW9+e5SSlxGNlV4j9cchG6a4fAZqxL+pS ks+KitK3ap/R4RUG+nbjLlhCwGJIti8lxvdYAoPqjtwEUmMJv4dIl0/2h1495cwBIi7XeRKZ Rx38TV3G3LCx0J8dFhkyTG5TxUZQFgHjznkIX7bzeSQX72MxT0b/tc38yM71WpAgAY+MlHCT FQRKqIQsH/4MFir+g/oV2uPNGwmg0QEOnv9zZ79JJ/nBmuXC2RwUVTtZgtiZXhaP0afvR0eg WPEzptIZZCSmtBOOYkfsAw==
Message-ID: <9b67d8a7-a4ab-7239-f1c3-f9de7976ff2e@innovationslab.net>
Date: Mon, 24 Aug 2020 09:27:34 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <9712A8B7-C516-499C-BE3E-2CEC19D9B0CB@nwtime.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/BGrCxi51uNVtWRILJvKizZWQonM>
Subject: Re: [Ntp] Éric Vyncke's No Objection on draft-ietf-ntp-mode-6-cmds-09: (with COMMENT)
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2020 13:27:40 -0000

Hi Harlan,

On 8/24/20 9:18 AM, Harlan Stenn wrote:
> One question before I fall asleep. 
> 
> Why is the lexicographic order if the addresses returned by ifstats significant?

The text Éric is referring to is this: "Read ordered list (11):
Retrieves an ordered list" and I interpreted his question to be "how are
they ordered".

My recollection is that lexicographic ordering is used. If that is not
the case, or that ordering is unimportant, please let me know.

Regards,
Brian

> 
> Sent from my iPhone - please excuse brevity and typos
> 
>> On Aug 24, 2020, at 6:12 AM, Eric Vyncke (evyncke) <evyncke=40cisco.com@dmarc.ietf.org> wrote:
>>
>> Hello Brian,
>>
>> Thank you for your reply, I fully agree to all your proposed changes (and of course, with your explanation, my comment on section 2 is no more relevant)
>>
>> Regards
>>
>> -éric
>>
>> -----Original Message-----
>> From: Brian Haberman <brian@innovationslab.net>
>> Date: Monday, 24 August 2020 at 14:32
>> To: Eric Vyncke <evyncke@cisco.com>, The IESG <iesg@ietf.org>
>> Cc: <draft-ietf-ntp-mode-6-cmds@ietf.org>, <ntp-chairs@ietf.org>, <ntp@ietf.org>, Karen O'Donoghue <odonoghue@isoc.org>
>> Subject: Re: Éric Vyncke's No Objection on draft-ietf-ntp-mode-6-cmds-09: (with COMMENT)
>>
>>    Hi Éric,
>>         Thanks for the review! Responses to your questions/comments below.
>>
>>    Regards,
>>    Brian
>>
>>>    On 8/21/20 10:32 AM, Éric Vyncke via Datatracker wrote:
>>> Éric Vyncke has entered the following ballot position for
>>> draft-ietf-ntp-mode-6-cmds-09: No Objection
>>>
>>> When responding, please keep the subject line intact and reply to all
>>> email addresses included in the To and CC lines. (Feel free to cut this
>>> introductory paragraph, however.)
>>>
>>>
>>> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
>>> for more information about IESG DISCUSS and COMMENT positions.
>>>
>>>
>>> The document, along with other ballot positions, can be found here:
>>> https://datatracker.ietf.org/doc/draft-ietf-ntp-mode-6-cmds/
>>>
>>>
>>>
>>> ----------------------------------------------------------------------
>>> COMMENT:
>>> ----------------------------------------------------------------------
>>>
>>> Thank you for the work put into this document.
>>>
>>> First, I must admit that this is the first time I see an IETF stream
>>> informational document for the specification of a control protocol used by an
>>> obsoleted RFC 1305. This document is much easier to read than the appendix B of
>>> RFC 1305 and the author takes care to write that this spec is not mandatory to
>>> implement but I really wonder why this document exists ?
>>>
>>> Moreover the abstract says "The goal of this document is to provide a current,
>>> but historic, " so why not publishing this document as 'historic' rather than
>>> 'informal' (datatracker seems to allow this modification).
>>>
>>
>>    The document was intended to be published as Historic, but it was
>>    changed to Informational during IETF Last Call. I fixed the Intended
>>    Status, but failed to update the Intro/Abstract to point out that this
>>    specification is intended to document mode-6 so that it is compatible
>>    with any RFC 5905 implementations that want to use it.
>>
>>    Would it help if I made the following changes?
>>
>>    Abstract
>>    --------
>>
>>    OLD:
>>    The goal of this document is to provide a current, but historic,
>>    description of the control messages as described in RFC 1305 and any
>>    additional commands implemented in NTP.
>>
>>    NEW:
>>    The goal of this document is to provide an updated description of the
>>    control messages described in RFC 1305 in order to conform with the
>>    updated Network Time Protocol specification documented in RFC 5905.
>>
>>    Introduction
>>    ------------
>>
>>    OLD:
>>    The control messages are described here as a historical record given
>>    their use within NTPv4.
>>
>>    NEW:
>>    The control messages are described here as a current reference for use
>>    with an RFC 5905 implementation.
>>
>>> Please find below a couple of non-blocking COMMENTs (and I would appreciate a
>>> reply to each of my COMMENTs) and some NITs.
>>>
>>> I hope that this helps to improve the document,
>>>
>>> Regards,
>>>
>>> -éric
>>>
>>> == COMMENTS ==
>>>
>>> -- Section 1.1 --
>>> Suggest to replace 'IP' by 'IPv4' in 'IP hosts are not required to reassemble
>>> datagrams larger than 576' + add some text that this document applies the same
>>> limitation to IPv6.
>>
>>    OLD:
>>    IP hosts are not required to reassemble datagrams larger than 576 octets
>>    [RFC0791];
>>
>>    NEW:
>>    IP hosts are not required to reassemble datagrams over a certain size
>>    (576 octets for IPv4 [RFC0791] and 1280 octets for IPv6 [RFC2460]);
>>
>>>
>>> -- Section 2 --
>>> Possibly linked to my lack of understanding of the purpose of this document,
>>> but, if applicable only to NTPv3, then should the Version number clearly
>>> specified to be 3 ?
>>
>>    As noted above, this spec is not limited to NTPv3 support, so I don't
>>    see a need to make a change.
>>
>>>
>>> -- Section 3.2 --
>>> Suggest to add 'bit' after 'Peer Status' in the table headings to make it clear.
>>
>>    Will do.
>>
>>>
>>> -- Section 4 --
>>> It will probably be useful to expand 'MRU' at first use.
>>>
>>
>>    Will do.
>>
>>> In the "Read ordered list (11):" it is not clear how the entries are ordered in
>>> the case of "ifstats" is it per local address ? Are IPv4 addresses before IPv6
>>> addresses ?
>>>
>>
>>    I will clarify that it is lexigraphical ordering with IPv4 information
>>    presented followed by IPv6 information.
>>
>>> -- Appendix A --
>>> Is there a reason why the mode 7 is in the appendix and not in the main body ?
>>>
>>
>>    The mode 7 approach is more implementation specific and there was not
>>    any interest within the WG to standardize anything beyond the frame format.
>>
>>> == NITS ==
>>>
>>
>>    Will fix these.
>>
>>> -- Section 2 --
>>> s/Conains/Contains/
>>>
>>> -- Section 4 --
>>> Should there be a comma in 'seven characters "ifstats" the associated' before
>>> 'the associated' ?
>>>
>>>
>>>
>>
>>
>> _______________________________________________
>> ntp mailing list
>> ntp@ietf.org
>> https://www.ietf.org/mailman/listinfo/ntp