Re: [Ntp] Éric Vyncke's No Objection on draft-ietf-ntp-mode-6-cmds-09: (with COMMENT)

Brian Haberman <brian@innovationslab.net> Mon, 24 August 2020 12:32 UTC

Return-Path: <brian@innovationslab.net>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B7B83A0D61 for <ntp@ietfa.amsl.com>; Mon, 24 Aug 2020 05:32:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.945
X-Spam-Level:
X-Spam-Status: No, score=-0.945 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-0.948, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=innovationslab-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pZIayCNypZ26 for <ntp@ietfa.amsl.com>; Mon, 24 Aug 2020 05:32:37 -0700 (PDT)
Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8FDCE3A0D5E for <ntp@ietf.org>; Mon, 24 Aug 2020 05:32:37 -0700 (PDT)
Received: by mail-qk1-x736.google.com with SMTP id p4so7157720qkf.0 for <ntp@ietf.org>; Mon, 24 Aug 2020 05:32:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innovationslab-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to; bh=sAZIzZ8YXE4z1ZzajwYm5kw3OGmYAeZ/NQn4xGcnvpA=; b=ojQwE5w1BQBuLxyo/uQlgNWIbffbct2Rp6C4ke0IGGkXZL5nRfVtrxwzyjAPX3DWlj Gu1SiFsQqJhZ2FiggeNyEo/fktsvoD+v45k1NgNJyPYTs2kDU2VvVTcMpHGSmxSv11VF Qq2DaxXYZHj6JKc1CCoqPu3vKrqD3PwB02EqVErXr7QFEceLSAAul/zLdiywPv3sEh1y cGKSsScIkVj6HBcXgqqcVqBmEEh4Q5bIj2crh+Bpp53q0rDe+v3QrUpB2NWQ6JGARiJf VJqMVFFZ1L0bB3tVXCt1uxcMXTHcK6tdmsEEJvdUjT2ALexdLDpK58km77Cm/9pXIBIu vSPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=sAZIzZ8YXE4z1ZzajwYm5kw3OGmYAeZ/NQn4xGcnvpA=; b=HmMEoA1io4aZeXrly6Hg5cRpnCjvFcq2+UrYPUE9VzaHA61vOiCU/y2t8NL2ZoMljc /U/K+bseLWKTLlE3mS8p+c/ovQWaTXmMZucQvgbLxTd36aCO6N5fmGPvz6kF7umxf5t4 hr9SSgrh/YGQj+Ov8qx6DB72DCAw45DdQ595kCTQgcCayUyhJO4Q1Ruy1WKK1K6vsZAT 2MVALr48cnmPCqexS8YO3SMxMHiTe6t9K7hPEVi2dqYMeOnPctOiccaeY4NzcJ+ESc++ TBE3dCx+8el5Lsh1p6BPpJOwspKQq/VIU0TAc4TwGUSpXUm+hWnQ630uzji0NLQYDc7C 1M+Q==
X-Gm-Message-State: AOAM532AFhJDr0HfdL8GC8InqlB9sSYvhGPS4+tOxMcrNiks4N8xwpi2 bChpD3pXzlVyXq1u9S3IXZp3XA==
X-Google-Smtp-Source: ABdhPJwxGpPXjHKkWmJB3+7z08ZwOLy7hbtWzjxP7IuKYH/pM6RH2guKKuZKXallyGNheuAJrTZtKw==
X-Received: by 2002:a37:4d13:: with SMTP id a19mr2511564qkb.456.1598272356508; Mon, 24 Aug 2020 05:32:36 -0700 (PDT)
Received: from LakeHartwell.local ([2601:154:c001:f99e:c9dc:45bf:24ef:2791]) by smtp.gmail.com with ESMTPSA id b10sm606949qkg.97.2020.08.24.05.32.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 05:32:35 -0700 (PDT)
To: Éric Vyncke <evyncke@cisco.com>, The IESG <iesg@ietf.org>
Cc: draft-ietf-ntp-mode-6-cmds@ietf.org, ntp-chairs@ietf.org, ntp@ietf.org, Karen O'Donoghue <odonoghue@isoc.org>
References: <159802037308.10371.11780852739141456472@ietfa.amsl.com>
From: Brian Haberman <brian@innovationslab.net>
Autocrypt: addr=brian@innovationslab.net; keydata= mQINBFm5KgYBEACs2icafejrG19L5DRNFq8Q2O+K+LRxjR4qAElZDnXFXNA2ipFWPeT0J2wa KJ+h9UdfhDm8DzULB553CYm+Q3XF1N56TglkIRMZYc7mYXZEr3x7e4fmX4kD4qMjBLG8cL26 rEe3Q0qaiMGY69/4o5coVMT0qmHjgCH1tkG+L2Y8MKr1gFxS18eO8MVoWe1yDKuyxFSElHGB 3mZn4gcqeCaemPGG3CiVNlp4KnijpNcSgvseXbkQEA4IXEsIvUL8MIwOTXg9Gh5cbtisZpuf +4B0LNMUSqWlqyKd9M3KCMj+dW4vsFytc00Z+GyQ+ArOR9GwTdAwJ5qqVODTvbjKqOR1zolJ 1JxLUtSiv7Lx5x2OrCexPYXkzlTkjG9Imtg2XNh55R/JKMC3KU1NQL3nS9tJXeoRWNgWSZrG MsrbeejbqLVb9LblXNpgLciJ96XHMvYAXX7p4LAwivzSRrVg46vErYIAV6EvDvwVENWW8JCU 0vX5iTGfkEwU4KxCa7WAmmD8yiNspHP1J0uk93Sta5K0PuTi7b+EZlCjdrqOEWLGPv6qXlIu FwLLcCaDs3XdVvwgNM+UFRxFH1aOVQQKCiCOCcNlwgYG1u4ZbD2T6hd/d2tOAKu/MNnQVF7d Cfi2BtSjzglLcY61e37zqTM04BgU+LniZ7V99yneM6DM2UzgkwARAQABtClCcmlhbiBIYWJl cm1hbiA8YnJpYW5AaW5ub3ZhdGlvbnNsYWIubmV0PokCQAQTAQoAKgIbAwUJB4YfgAULCQgH AwUVCgkICwUWAgMBAAIeAQIXgAUCWbkqSAIZAQAKCRBo1jycU9GLYQixD/9UX0uiAvbJ+4dK z3Ne3kUdDK0Lk73RGfFgE/ezsc9I6ED82h+arC8pAoDnBWgzTxugZdbexek983bgMq02XFsG pJf7hudeKnB8UmtjTc0j1UUgi129FYyBmINS2Lz1gpEOygFfbeOGLJK5qZJwD3I3O6yN8SUZ uwahXXd1aEB+d1eGhNqxkjQ+L7vdfTlN662GWog3ROMwUbrg0+QAbn/Vlp2iIYO6VERUZ9Yr GfFJX9b9LKa6AHxzAaqFIix1h2wBiIacpIBGU/4+3+wL5zkCbGSRzoIHW8srllj7ehgwwfNx QevibuZWJ4XpHpIxrtsmBO7ERFk8pN7oiQ9M3b2Cg9OBD5vgxyMCHEKIblWyKz8GLtz5357L ORU1EBWB8BoJPBHz3u7bZE+jH9+w5PpI087Ae78KCDkTNj7o2wbkRoYLmLpMo8DOwAumyy5R 2DuRu0cn5Rw5pFjlJkyfM0Wf80Ml/SINrUORWeqSbsHSX8i+Y0Oyt5JNo9NFbgN0Gn/Qo364 I8cLgbvUAyFHwhnmbHB+QXFCGAy73NOQ+g2fCRPeSbihhYa34ugfmd4oa6W2w805ixzM7iGr P+wDB1dhA7eHKVmoo9Kxvm9VzU+2homYGEROd/H6n0BMvWtp1oFh/JvEgZN6dVLg3p+XX5Zj Ggy568bIY4P5kP7pAxh017kCDQRZuSoGARAAtCWxW1cRne/iGbFuibvB8d3upcbCB7oz4LWk LSE20Db2ymn04ici9V+wBSWX57me5jQdwMi/gzVVZcupbzWTg5Yhv7Qt7CKORJLEKo6nULbb 4aEpdOXD9s7wwx+foFjzjtDOH/JYoB+OEe2oW39VmK6EsIx7ClsLf6+cih5yApZHtmV+2M3J YSxD2kCUE619ITFLAkMf203ap5vJ6DDaaKnVoNhF9qV7jlJEceGqHTBG4KkBX/zNCehMIfhr ViY/B2IWAHeuZ99lnCPx2mehGGa4XLjQauUkY9KB7dOq/ODyt+7SL0dfWrOVf3BnU3C308b4 9YdId8KI4dJ30nfXn6ifTK9STZHZE+Mt1sIVmtEguqMXEk/axZmT14x194c7ZPmU/uCQTE3U y1NFs4Yof50WF1ze0CyN2ycmqx11mHjP5+L23TqcdIWmJG+EtdHUAFpu42kbB0fML3Oc/cEU SmWK3WpF5YPljLM2gyh3RXjuiBnaGoJaKTOj5zXQ2G2l3/ijbn9FbqmFup+R352dxUyakXEP xNe3HdyjfyUcy/RJNeZz/lgUIhkxWQjOOU1RIN41RtCKcF9tJjMwgQvI51QmPvf90/6ab3I/ vwEpjlRb4AbuWfPWe89J+Z3TG97V9sntlMcQ6MGiPLbyFpiXIf2150e6FxZdJtipVwY2d/kA EQEAAYkCJQQYAQoADwUCWbkqBgIbDAUJB4YfgAAKCRBo1jycU9GLYfy0EACYrxb4nWtOnIu0 N7rXXo/0ZjaBTyUhJ6hzy2D7rt3vv/qj2ui+N21ui/yMDS928za/XRfP25qN9A1puioHqN4l SAsxwCC3mT9GJXVXVgivg3MeciqBXoOdnk1hUkP1CTKL3qZ9pSuw8bPlNE7+b1xF7Oce37YH +QRVmBXbGwTxtDTCZ9Js0/IpiUtg9QCfmryB1r/fD0TFb8b9aCBuVeKocWSuX9UXRt7zRGM8 BJwOLvdLdGvV8us1imlBKFLai4L8CPgihuc/s7ZB0r3pgW697hXScWhGHF3OUWbPFVkNyivM xtDcq+9ZlUMrxFbwUEABi8NFwvzwn+YJQqlrPiF4xxsScYpnIlfWEuP6Vpp6Z/u5x+1MNyZb oxNWWaevMVeo3tdRV9F6/YFqucw4JQ9HqlCKQ62sW9+e5SSlxGNlV4j9cchG6a4fAZqxL+pS ks+KitK3ap/R4RUG+nbjLlhCwGJIti8lxvdYAoPqjtwEUmMJv4dIl0/2h1495cwBIi7XeRKZ Rx38TV3G3LCx0J8dFhkyTG5TxUZQFgHjznkIX7bzeSQX72MxT0b/tc38yM71WpAgAY+MlHCT FQRKqIQsH/4MFir+g/oV2uPNGwmg0QEOnv9zZ79JJ/nBmuXC2RwUVTtZgtiZXhaP0afvR0eg WPEzptIZZCSmtBOOYkfsAw==
Message-ID: <342f3ada-510c-187b-84a5-a7556fd7d928@innovationslab.net>
Date: Mon, 24 Aug 2020 08:32:33 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <159802037308.10371.11780852739141456472@ietfa.amsl.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="eYAtDjGgAiZ0lyu8l6bmj4M8AXJAG7Wpw"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/MnOoK6J7vMZF5dj7-Y_QM2N_rHM>
Subject: Re: [Ntp] Éric Vyncke's No Objection on draft-ietf-ntp-mode-6-cmds-09: (with COMMENT)
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2020 12:32:39 -0000

Hi Éric,
     Thanks for the review! Responses to your questions/comments below.

Regards,
Brian

On 8/21/20 10:32 AM, Éric Vyncke via Datatracker wrote:
> Éric Vyncke has entered the following ballot position for
> draft-ietf-ntp-mode-6-cmds-09: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-ntp-mode-6-cmds/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thank you for the work put into this document.
> 
> First, I must admit that this is the first time I see an IETF stream
> informational document for the specification of a control protocol used by an
> obsoleted RFC 1305. This document is much easier to read than the appendix B of
> RFC 1305 and the author takes care to write that this spec is not mandatory to
> implement but I really wonder why this document exists ?
> 
> Moreover the abstract says "The goal of this document is to provide a current,
> but historic, " so why not publishing this document as 'historic' rather than
> 'informal' (datatracker seems to allow this modification).
> 

The document was intended to be published as Historic, but it was
changed to Informational during IETF Last Call. I fixed the Intended
Status, but failed to update the Intro/Abstract to point out that this
specification is intended to document mode-6 so that it is compatible
with any RFC 5905 implementations that want to use it.

Would it help if I made the following changes?

Abstract
--------

OLD:
The goal of this document is to provide a current, but historic,
description of the control messages as described in RFC 1305 and any
additional commands implemented in NTP.

NEW:
The goal of this document is to provide an updated description of the
control messages described in RFC 1305 in order to conform with the
updated Network Time Protocol specification documented in RFC 5905.

Introduction
------------

OLD:
The control messages are described here as a historical record given
their use within NTPv4.

NEW:
The control messages are described here as a current reference for use
with an RFC 5905 implementation.

> Please find below a couple of non-blocking COMMENTs (and I would appreciate a
> reply to each of my COMMENTs) and some NITs.
> 
> I hope that this helps to improve the document,
> 
> Regards,
> 
> -éric
> 
> == COMMENTS ==
> 
> -- Section 1.1 --
> Suggest to replace 'IP' by 'IPv4' in 'IP hosts are not required to reassemble
> datagrams larger than 576' + add some text that this document applies the same
> limitation to IPv6.

OLD:
IP hosts are not required to reassemble datagrams larger than 576 octets
[RFC0791];

NEW:
IP hosts are not required to reassemble datagrams over a certain size
(576 octets for IPv4 [RFC0791] and 1280 octets for IPv6 [RFC2460]);

> 
> -- Section 2 --
> Possibly linked to my lack of understanding of the purpose of this document,
> but, if applicable only to NTPv3, then should the Version number clearly
> specified to be 3 ?

As noted above, this spec is not limited to NTPv3 support, so I don't
see a need to make a change.

> 
> -- Section 3.2 --
> Suggest to add 'bit' after 'Peer Status' in the table headings to make it clear.

Will do.

> 
> -- Section 4 --
> It will probably be useful to expand 'MRU' at first use.
> 

Will do.

> In the "Read ordered list (11):" it is not clear how the entries are ordered in
> the case of "ifstats" is it per local address ? Are IPv4 addresses before IPv6
> addresses ?
> 

I will clarify that it is lexigraphical ordering with IPv4 information
presented followed by IPv6 information.

> -- Appendix A --
> Is there a reason why the mode 7 is in the appendix and not in the main body ?
> 

The mode 7 approach is more implementation specific and there was not
any interest within the WG to standardize anything beyond the frame format.

> == NITS ==
> 

Will fix these.

> -- Section 2 --
> s/Conains/Contains/
> 
> -- Section 4 --
> Should there be a comma in 'seven characters "ifstats" the associated' before
> 'the associated' ?
> 
> 
>