Re: [OPSAWG] I-D Action: draft-ietf-opsawg-l2nm-09.txt

Hi Tom, 

I confirm that Figure 12 is correct. 

What is authoritative is the YANG module. We provided the reader with instructions to generate the full tree:

   The full tree diagram of the module can be generated using the
   "pyang" tool [PYANG].  

It is much more easier to include the full tree and update it once when the module is touched but having a tree spanning dozens of pages is not usable. This is why we are using subtrees:

   That tree is not included here because it is
   too long (Section 3.3 of [RFC8340]).  Instead, subtrees are provided
   for the reader's convenience.

However, this approach has some cons as we need to check manually many many figures. We are doing our best to maintain up-to-date subtrees ... but bugs happen. 

Thank you for helping identifying some of those. 

Cheers,
Med

> -----Message d'origine-----
> De : tom petch <ietfc@btconnect.com>
> Envoyé : lundi 8 novembre 2021 13:51
> À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com>;
> adrian@olddog.co.uk; opsawg@ietf.org
> Objet : Re: I-D Action: draft-ietf-opsawg-l2nm-09.txt
> 
> From: mohamed.boucadair@orange.com <mohamed.boucadair@orange.com>
> Sent: 08 November 2021 07:38
> Hi Adrian, Tom, all,
> 
> The comments raised by Tom are now addressed in -10.
> 
> <tp A fresh comment on -09 which also applies to -10.
> In Figure 12 I see
>              |           +--rw saii?                      uint32
>              |           +--rw remote-targets* [taii]
>              |           |  +--rw taii         uint32
>              |           |  +--rw peer-addr    inet:ip-address
>  while in Figure 13 I see
>              |           +--rw saii?                      uint32
>              |           +--rw remote-target* [peer-addr taii]
>              |           |  +--rw peer-addr    inet:ip-address
>              |           |  +--rw taii         uint32
> 
> i.e. a change of identifier for the list, a change in keys, a change in
> leaf order.  The YANG suggests that Figure 13 is wrong.  More
> fundamentally, YANG tree diagrams are an aid to understanding and
> reviewing especially with a module as big as this.  If they cannot be
> trusted, then what can?
> 
> Tom Petch
> 
> 
> Two comments on idnits:
> 
> (1) obsolete reference:
> 
>   -- Obsolete informational reference (is this intentional?): RFC 5143
>      (Obsoleted by RFC 4842)
> 
> This is on purpose as we are following what is in:
> https://www.iana.org/assignments/pwe3-parameters/pwe3-
> parameters.xhtml#pwe3-parameters-2.
> 
> (2) long lines:
> 
> idnits is clean when I run it prior to submission:
> 
> ==
> 
>   Checking nits according to https://www.ietf.org/id-info/checklist :
>   ------------------------------------------------------------------------
> ----
> 
>      No issues found here.
> ==
> 
> However, the datatracker displays the following after submission:
> 
> ==
>   Checking nits according to https://www.ietf.org/id-info/checklist :
>   ------------------------------------------------------------------------
> ----
> 
>   ** There are 132 instances of too long lines in the document, the
> longest
>      one being 3 characters in excess of 72.
> ==
> 
> Will see how to fix this.
> 
> Cheers,
> Med
> 
> 
> > -----Message d'origine-----
> > De : Adrian Farrel <adrian@olddog.co.uk> Envoyé : lundi 1 novembre
> > 2021 13:57 À : 'tom petch' <ietfc@btconnect.com>; BOUCADAIR Mohamed
> > INNOV/NET <mohamed.boucadair@orange.com>; opsawg@ietf.org Objet : RE:
> > I-D Action: draft-ietf-opsawg-l2nm-09.txt
> >
> > Useful comments, thanks Tom.
> >
> > Authors, please run idnits and fix issues. Also address Tom's comments.
> >
> > I'll be doing my shepherd review this week. Hopefully you can post a
> > new revision when the gates open next Monday.
> >
> > Cheers,
> > Adrian
> >
> > -----Original Message-----
> > From: tom petch <ietfc@btconnect.com>
> > Sent: 01 November 2021 12:48
> > To: mohamed.boucadair@orange.com; opsawg@ietf.org
> > Cc: adrian@olddog.co.uk
> > Subject: Re: I-D Action: draft-ietf-opsawg-l2nm-09.txt
> >
> > From: OPSAWG <opsawg-bounces@ietf.org> on behalf of
> > mohamed.boucadair@orange.com <mohamed.boucadair@orange.com>
> > Sent: 20 October 2021 09:49
> > Hi all,
> >
> > After discussing with Adrian, we are publishing this version that
> > addresses a recent comment from Julian. For more context, please refer
> > to https://github.com/IETF-OPSAWG-WG/lxnm/issues/350.
> >
> > <tp>
> > Some stray thoughts
> >
> > some lines are 90 characters long
> >
> > 802.1ah is referenced but not in I-D References 802.3ah ditto 802.1ag
> > Amendment 5 looks like a separate document warranting a separate
> > reference 802.1p is referenced implicitly 802.1Q likewise
> >
> > What is the difference between
> > identity bgp-l2encaps-type
> >   Base BGP L2 encapsulation type
> >      and
> > identity iana-pw-types
> >  Base BGP L2 encapsulation type
> >
> > ccm-priority-type
> > what is high what low?
> >
> > Local Maintenance End Point (MEP)
> > This is not the expansion used by the ITU-T
> >
> > leaf split-horizon-filtering
> > what does true mean?
> >
> > leaf ccm-interval
> > no units
> >
> > leaf ccm-holdtime
> > no units
> >
> > leaf duplicate-ip-detection-interval
> > no units
> >
> > leaf duplicate-ip-detection-interval
> > no units
> >
> >
> > Tom Petch
> >
> > Cheers,
> > Med
> >
> > > -----Message d'origine-----
> > > De : I-D-Announce <i-d-announce-bounces@ietf.org> De la part de
> > > internet- drafts@ietf.org Envoyé : mercredi 20 octobre 2021 10:34 À :
> > > i-d-announce@ietf.org Cc : opsawg@ietf.org Objet : I-D Action:
> > > draft-ietf-opsawg-l2nm-09.txt
> > >
> > >
> > > A New Internet-Draft is available from the on-line Internet-Drafts
> > > directories.
> > > This draft is a work item of the Operations and Management Area
> > > Working Group WG of the IETF.
> > >
> > >         Title           : A Layer 2 VPN Network YANG Model
> > >         Authors         : Samier Barguil
> > >                           Oscar Gonzalez de Dios
> > >                           Mohamed Boucadair
> > >                           Luis Angel Munoz
> > >       Filename        : draft-ietf-opsawg-l2nm-09.txt
> > >       Pages           : 155
> > >       Date            : 2021-10-20
> > >
> > > Abstract:
> > >    This document defines an L2VPN Network YANG Model (L2NM) that can
> be
> > >    used to manage the provisioning of Layer 2 Virtual Private Network
> > >    (VPN) services within a network (e.g., service provider network).
> > >    The L2NM complements the Layer 2 Service Model (L2SM) by providing
> a
> > >    network-centric view of the service that is internal to a service
> > >    providers.  The L2NM is particularly meant to be used by a network
> > >    controller to derive the configuration information that will be
> sent
> > >    to relevant network devices.
> > >
> > >    Also, the document defines the initial versions of two IANA-
> > >    maintained modules that defines a set of identities of BGP Layer 2
> > >    encapsulation types and pseudowire types.
> > >
> > >
> > > The IETF datatracker status page for this draft is:
> > > https://datatracker.ietf.org/doc/draft-ietf-opsawg-l2nm/
> > >
> > > There is also an htmlized version available at:
> > > https://datatracker.ietf.org/doc/html/draft-ietf-opsawg-l2nm-09
> > >
> > > A diff from the previous version is available at:
> > > https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-l2nm-09
> > >
> > >
> > > Internet-Drafts are also available by anonymous FTP at:
> > > ftp://ftp.ietf.org/internet-drafts/
> > >
> > >
> > > _______________________________________________
> > > I-D-Announce mailing list
> > > I-D-Announce@ietf.org
> > > https://www.ietf.org/mailman/listinfo/i-d-announce
> > > Internet-Draft directories: http://www.ietf.org/shadow.html or
> > > ftp://ftp.ietf.org/ietf/1shadow-sites.txt
> >
> > ______________________________________________________________________
> > ____
> > __
> > _____________________________________________
> >
> > Ce message et ses pieces jointes peuvent contenir des informations
> > confidentielles ou privilegiees et ne doivent donc pas etre diffuses,
> > exploites ou copies sans autorisation. Si vous avez recu ce message
> > par erreur, veuillez le signaler a l'expediteur et le detruire ainsi
> > que les pieces jointes. Les messages electroniques etant susceptibles
> > d'alteration, Orange decline toute responsabilite si ce message a ete
> > altere, deforme ou falsifie. Merci.
> >
> > This message and its attachments may contain confidential or
> > privileged information that may be protected by law; they should not
> > be distributed, used or copied without authorisation.
> > If you have received this email in error, please notify the sender and
> > delete this message and its attachments.
> > As emails may be altered, Orange is not liable for messages that have
> > been modified, changed or falsified.
> > Thank you.
> >
> > _______________________________________________
> > OPSAWG mailing list
> > OPSAWG@ietf.org
> > https://www.ietf.org/mailman/listinfo/opsawg
> > =
> 
> 
> __________________________________________________________________________
> _______________________________________________
> 
> Ce message et ses pieces jointes peuvent contenir des informations
> confidentielles ou privilegiees et ne doivent donc pas etre diffuses,
> exploites ou copies sans autorisation. Si vous avez recu ce message par
> erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les
> pieces jointes. Les messages electroniques etant susceptibles
> d'alteration, Orange decline toute responsabilite si ce message a ete
> altere, deforme ou falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged
> information that may be protected by law; they should not be distributed,
> used or copied without authorisation.
> If you have received this email in error, please notify the sender and
> delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been
> modified, changed or falsified.
> Thank you.

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.