Re: [OPSAWG] I-D Action: draft-ietf-opsawg-l2nm-09.txt

[tom petch <[e-mail]>]

From: [e-mail] <[e-mail]>
Sent: 02 November 2021 09:30

Hi Tom,

Thank you for the comments.
<tp>

Med

As you may have surmised, I am working my way through the I-D but do not have a view yet of how long it will take so would not suggest waiting but rather, if you let me know what your deadline is for preparing a new version, as Adrian suggests, then I will send you my comments so far at that time.

In addition to my previous remarks, I note that two import in 8.3 lack YANG reference clauses.

Tom Petch 


Please see inline.

Cheers,
Med

> -----Message d'origine-----
> De : tom petch <[e-mail]>
> Envoyé : lundi 1 novembre 2021 13:48
>
> From: OPSAWG <[e-mail]> on behalf of
> [e-mail] <[e-mail]>
> Sent: 20 October 2021 09:49
> Hi all,
>
> After discussing with Adrian, we are publishing this version that
> addresses a recent comment from Julian. For more context, please refer to
> https://github.com/IETF-OPSAWG-WG/lxnm/issues/350.
>
> <tp>
> Some stray thoughts
>
> some lines are 90 characters long

[Med] Will check and fix as appropriate.

>
> 802.1ah is referenced but not in I-D References
[Med] Indeed. Fixed.

 802.3ah
[Med] Fixed.

ditto 802.1ag

[Med] This one is already referenced as IEEE-802-1ag.

> Amendment 5 looks like a separate document warranting a separate reference
> 802.1p is referenced implicitly 802.1Q likewise

[Med] As you know 802.1p is not a separate standard. Referenced 802.1Q in the text instead.

>
> What is the difference between
> identity bgp-l2encaps-type
>   Base BGP L2 encapsulation type
>      and
> identity iana-pw-types
>  Base BGP L2 encapsulation type
>

[Med] This is a typo. This should be "Base Pseudowire L2 encapsulation type"

> ccm-priority-type
> what is high what low?

[Med] Added the following to the description:

"A larger value indicates a higher priority."

>
> Local Maintenance End Point (MEP)
> This is not the expansion used by the ITU-T

[Med] Updated to "Maintenance Entity Group End Point (MEP)".

>
> leaf split-horizon-filtering
> what does true mean?

[Med] Made this change:

OLD:
          "Controls split-horizon filtering.

           In order to achieve split-horizon filtering, every
           Broadcast, unknown unicast, or multicast (BUM)
           packet originating from a non-DF PE is encapsulated
           with an MPLS label that identifies the origin ES.";

NEW:
          "Controls split-horizon filtering. It is enabled
           when set to 'true'.

           In order to achieve split-horizon filtering, every
           Broadcast, unknown unicast, or multicast (BUM)
           packet originating from a non-DF PE is encapsulated
           with an MPLS label that identifies the origin ES.";

>
> leaf ccm-interval
> no units

[Med] Added "milliseconds". Thanks.

>
> leaf ccm-holdtime
> no units

[Med] Added "milliseconds".

>
> leaf duplicate-ip-detection-interval
> no units
>
> leaf duplicate-ip-detection-interval
> no units

[Med] updated to indicate "seconds".

>
>
> Tom Petch
>
> Cheers,
> Med
>
> > -----Message d'origine-----
> > De : I-D-Announce <[e-mail]> De la part de
> > internet- [e-mail] Envoyé : mercredi 20 octobre 2021 10:34 À :
> > [e-mail] Cc : [e-mail] Objet : I-D Action:
> > draft-ietf-opsawg-l2nm-09.txt
> >
> >
> > A New Internet-Draft is available from the on-line Internet-Drafts
> > directories.
> > This draft is a work item of the Operations and Management Area
> > Working Group WG of the IETF.
> >
> >         Title           : A Layer 2 VPN Network YANG Model
> >         Authors         : Samier Barguil
> >                           Oscar Gonzalez de Dios
> >                           Mohamed Boucadair
> >                           Luis Angel Munoz
> >       Filename        : draft-ietf-opsawg-l2nm-09.txt
> >       Pages           : 155
> >       Date            : 2021-10-20
> >
> > Abstract:
> >    This document defines an L2VPN Network YANG Model (L2NM) that can be
> >    used to manage the provisioning of Layer 2 Virtual Private Network
> >    (VPN) services within a network (e.g., service provider network).
> >    The L2NM complements the Layer 2 Service Model (L2SM) by providing a
> >    network-centric view of the service that is internal to a service
> >    providers.  The L2NM is particularly meant to be used by a network
> >    controller to derive the configuration information that will be sent
> >    to relevant network devices.
> > and pseudowire types.
> >