IETF Logo Mail Archive

Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)

Mike Bishop <notifications@github.com> Tue, 07 August 2018 21:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A76F6129AB8 for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 14:08:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cOKhJKJu5a5d for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 14:08:34 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 51E59130E05 for <quic-issues@ietf.org>; Tue, 7 Aug 2018 14:08:34 -0700 (PDT)
Date: Tue, 07 Aug 2018 14:08:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533676113; bh=6xOGzigRmwts0IFv8MiOYO/tgHTWtT/QZIEWh9bNih8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=II4M5a4s79rEtjgDdUHCQ4bRyhSVawPTL5MsfWV3KUvuUFbc+rQiR+NBSG4TbGFG1 vkD6pcZ+mmzs5xgFvvZVmjmpPtUuluC1iBiqCFbDdKkp5qIxR9hYFeiEym9Qe5R9JQ zNo60UH8Sp14VQ1TEtAfGY2Kc3YYFzoYYVyXdk3E=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf5a866329fd8d8f3e3175c590c1aa0f2a7a6e82792cf000000011781cc5192a169ce14c4e0aa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1637/review/144185455@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1637@github.com>
References: <quicwg/base-drafts/pull/1637@github.com>
Subject: Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6a0a5138372_47e73f8458abe6241016fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/43mCViTHwxiFGm8ABv0fWqeWDfE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2018 21:08:36 -0000

MikeBishop commented on this pull request.

Given that it's a compound adjective, wouldn't it be "application-limited" throughout?

> @@ -1115,13 +1119,19 @@ acked_packet from sent_packets.
 ~~~
    InRecovery(packet_number):
      return packet_number <= end_of_recovery
+   
+   IsAppLimited():
+     bytes_in_flight >= congestion_window - kMaximumDatagramSize

Isn't this backward?  Bytes in flight can't be greater than the congestion window, but if the bytes in flight are within one datagram of the window, you're clearly not limited.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1637#pullrequestreview-144185455

v2.23.0 | Report a Bug | By Email