Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)

Jana Iyengar <notifications@github.com> Mon, 28 January 2019 05:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2ED23130FA3 for <quic-issues@ietfa.amsl.com>; Sun, 27 Jan 2019 21:45:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IKki4hD0sjIE for <quic-issues@ietfa.amsl.com>; Sun, 27 Jan 2019 21:45:33 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40C3D12DF72 for <quic-issues@ietf.org>; Sun, 27 Jan 2019 21:45:33 -0800 (PST)
Date: Sun, 27 Jan 2019 21:45:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548654332; bh=qEaz4YhV0Q+EZBH9aQeAjESYkspY97bkW+21159gJIU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eD1HK6pL///4O9yX2fSBAitg64SBH94quujNDNmWrTSOAFJvwx34z4sO1NU6gHF5M piie0I2vkeuS+NpwxaKNXat4kLs1ncqnijHogdm2lvIj1s49GzlWo461SOVsEOHMv2 ow990VFlrAki4Vse9G2kh6QWkbWdIXK4E+ai6MW8=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6847cc417861533d80059b5f7d4b2999ea0d368192cf00000001186658fc92a169ce14c4e0aa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1637/review/196879726@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1637@github.com>
References: <quicwg/base-drafts/pull/1637@github.com>
Subject: Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4e96fc70a7b_7af83f871e0d45b41430d5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lpewzolXVnAu14B-lyan9F_h_SA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jan 2019 05:45:35 -0000

janaiyengar commented on this pull request.



> @@ -1047,6 +1045,19 @@ paces the sending of any packets in excess of the initial congestion window.
 A sender MAY implement alternate mechanisms to update its congestion window
 after idle periods, such as those proposed for TCP in {{?RFC7661}}.
 
+## Application Limited Sending
+
+The congestion window should not be increased in slow start or congestion
+avoidance when it is not fully utilized.  The congestion window could be
+under-utilized due to insufficient application data to send or flow control

```suggestion
under-utilized due to insufficient application data or flow control credit.
```

> @@ -1047,6 +1045,19 @@ paces the sending of any packets in excess of the initial congestion window.
 A sender MAY implement alternate mechanisms to update its congestion window
 after idle periods, such as those proposed for TCP in {{?RFC7661}}.
 
+## Application Limited Sending
+
+The congestion window should not be increased in slow start or congestion
+avoidance when it is not fully utilized.  The congestion window could be
+under-utilized due to insufficient application data to send or flow control
+limits.

```suggestion
```

> @@ -1047,6 +1045,19 @@ paces the sending of any packets in excess of the initial congestion window.
 A sender MAY implement alternate mechanisms to update its congestion window
 after idle periods, such as those proposed for TCP in {{?RFC7661}}.
 
+## Application Limited Sending
+
+The congestion window should not be increased in slow start or congestion
+avoidance when it is not fully utilized.  The congestion window could be
+under-utilized due to insufficient application data to send or flow control
+limits.
+
+When the sender is pacing (see {{pacing}}) packets, the sender may be unable
+to use the full congestion window for a period of time after receiving
+acknowledgements, due to pacing.  In this case, the sender should not consider
+themselves application limited and should allow the congestion window to
+increase.

Suggested rephrasing:  "A sender that uses pacing (see {{pacing}}) might delay sending of packets and might not fully utilize the congestion window due to this delay.  A sender should not consider itself application limited if it might have utilized the entire congestion window without pacing delay."

"When the sender paces packets (see {{pacing}}), it might not send 
to use the full congestion window for a period of time after receiving
acknowledgements, due to pacing.  In this case, the sender should not consider
themselves application limited and should allow the congestion window to
increase."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1637#pullrequestreview-196879726