IETF Logo Mail Archive

Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)

ianswett <notifications@github.com> Fri, 11 January 2019 20:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32AD0128D0C for <quic-issues@ietfa.amsl.com>; Fri, 11 Jan 2019 12:42:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dhNyqvyrKytR for <quic-issues@ietfa.amsl.com>; Fri, 11 Jan 2019 12:42:38 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D8D3128B14 for <quic-issues@ietf.org>; Fri, 11 Jan 2019 12:42:38 -0800 (PST)
Date: Fri, 11 Jan 2019 12:42:37 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547239357; bh=PwFWsDQmBavgRwflus03ZB1zgk+tBFhb9L2uoQEk3Ss=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=noHsfQgxx1ODLaemxYgPDYubtHifWTALzJgKuUavtzb6/cvJ4YrDfXdclkmPM0J0O tDQkFDBE9gEGZjKCPYxWBt7lUFyzBFtOb4C/VpcCa+kSpXF4sSoRFG6CeRcb0wfxyo GLSt4PoK5oOMptN5134nFzCgFjEgKz6iMGbSQj88=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab72398a0b2187e9afac70a557e5bf5847974667ca92cf000000011850c1bd92a169ce14c4e0aa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1637/review/191858170@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1637@github.com>
References: <quicwg/base-drafts/pull/1637@github.com>
Subject: Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c38ffbd53ef7_dd03fa9b22d45c41073ee"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VIy9MdEglJmMUTpM99OKERwE1dk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 20:42:40 -0000

ianswett commented on this pull request.



>  
    OnPacketAckedCC(acked_packet):
      // Remove from bytes_in_flight.
      bytes_in_flight -= acked_packet.bytes
      if (InRecovery(acked_packet.packet_number)):
        // Do not increase congestion window in recovery period.
        return
+     if (IsAppLimited())
+       // Do not increase congestion_window if application limited.
+       return

Agreed, getting this right is complex.  I am going to not define the IsAppLimited() method, but document what it's intent is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1637#discussion_r247248134

v2.23.0 | Report a Bug | By Email