Re: [quicwg/base-drafts] Discuss Application-Limited Sending (#1637)

[Nick Banks <[e-mail]>]

nibanks commented on this pull request.



> @@ -1115,13 +1119,19 @@ acked_packet from sent_packets.
 ~~~
    InRecovery(packet_number):
      return packet_number <= end_of_recovery
+   
+   IsAppLimited():
+     bytes_in_flight >= congestion_window - kMaximumDatagramSize

I agree this is backward. The `>=` should just be `<` or `<=`. But as far as tracking `IsAppLimited()` or whatever you want to call it, I would just suggest a modification to the code:

Instead of using `bytes_in_flight` here and the helper function `IsAppLimited`, introduce a new variable `window_full` that is only set in `OnPacketSent`. At the end of each call to that function, if `bytes_in_flight` is close enough to `congestion_window` set it to true, otherwise false. Then below, you use that variable to decide if the cwnd should be increased..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1637#discussion_r208639187