Re: [quicwg/base-drafts] Boolean blocked streams setting (#3073)

[afrind <[e-mail]>]

I didn't find the numeric setting significantly more complicated to implement than a boolean setting.  The [diff](https://github.com/facebook/proxygen/commit/09cb1304fb52149b7343f9f22d44ed3efa130840#diff-cde3cb3125e1e0b319d8264cb67c7de8) that converted it from a boolean to a number touched about 25 lines of code in the encoder.  I find that the bigger complexity comes from having the implementation allow both blocking and non-blocking.

proxygen uses the count, which is incremented when sending a header block with a potentially blocking reference and decremented on acks and cancellations.  I don't decrement the count on Insert Count Increment, and I count multiple potentially blocking blocks on the same stream individually.  Both of these make the implementation more conservative than necessary, but the code is pretty simple.

As for a use case, lately I've been working with our RPC over HTTP stack, which generally sets the stream limit in the 100k range.  There's more of a case to be made for keeping the QPACK blocking limit lower than the stream limit when you've got a bonkers stream limit.  When the stream limit is 100 or something else webish, 10 vs. 50 vs 100 doesn't seem super meaningful.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3073#issuecomment-538012823