Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)

Dmitri Tikhonov <notifications@github.com> Tue, 31 July 2018 12:33 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 81015128CF2 for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 05:33:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.11
X-Spam-Level:
X-Spam-Status: No, score=-1.11 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jPI9dvqGdk8y for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 05:33:42 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9DBC3129AB8 for <quic-issues@ietf.org>; Tue, 31 Jul 2018 05:33:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Ed9NsVg4b3fijkjS5uoCmJcQeZQ=; b=jnHrAYQj3MLAuRk7 1881lD2bnU8gkuVq2J8aIaOUwewC6xXtV4RWp8D2lIqZ22jkbXClyGLbVTMVbChv WGNHcP726ow72Ss6J4CrL1F0jA34DISDscuiz/+ManG/yIN3tx4vCZMLbyWpl2qz r1Up8rDWtczpvFkcqs8MHcuI8M4=
Received: by filter1287p1mdw1.sendgrid.net with SMTP id filter1287p1mdw1-10044-5B6056A3-32 2018-07-31 12:31:31.856037587 +0000 UTC m=+482998.259821484
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) by ismtpd0027p1mdw1.sendgrid.net (SG) with ESMTP id 7cfS9ZsgTWi_rosJ7YbJvA for <quic-issues@ietf.org>; Tue, 31 Jul 2018 12:31:31.514 +0000 (UTC)
Date: Tue, 31 Jul 2018 12:31:32 +0000
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0c55441532d8f98f3ac7ad65f9bca17fa35f434c92cf000000011778189d92a169ce149fd7cc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1612/409203779@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1612@github.com>
References: <quicwg/base-drafts/issues/1612@github.com>
Subject: Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b60569d90ba0_52093fcc0f4d45c09396c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1gHtJl9QqTO8Zu2GCGurqjHXjRahhvzuC4hV XQxEnhg/bA2qx0xJQt4x8V11LojnSZfdyZ7erVWT/CiIEJuyt82MbwBfo/kH6JWaPCwkC8mvsR2o8v ZrBHRGOosGcJiCbGBechwlMmBidloY610dZF9ttbhzLDXWY7gtdBVPpgU0rjtnMFJDHNYnYfRMqQqg 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9Gw-wY1AGCMoTPfShV_sZWAKQGk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 12:33:51 -0000

@siyengar writes:
> a receiver who wants to help peers prevent flow control bugs from happening

One could detect _potential_ bugs in the peer in many other cases.  I vote against mandating such error detection at the protocol level.

@kazuho writes:
> some existing QUIC implementations simply retransmit a packet (by re-encrypting it using a new PN) when it is deemed lost. I think that such implementations should be allowed to exist.

This is true. This is what the LiteSpeed implementation does with GQUIC's _WINDOW_UPDATE_ frames. The smaller values are [ignored](https://github.com/litespeedtech/lsquic-client/blob/04468d215dc184ae64e7aa1d0e940da50c724e2f/src/liblsquic/lsquic_stream.c#L1855). It is more expedient (and is cheaper) to discard lower values on receipt rather than update or remove the old values on retransmit.

Yes, let us exist!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1612#issuecomment-409203779