Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)

Subodh Iyengar <notifications@github.com> Tue, 31 July 2018 15:01 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D706130E58 for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 08:01:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.11
X-Spam-Level:
X-Spam-Status: No, score=-1.11 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ttDLNJXkx2sU for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 08:00:55 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4B6E130E2E for <quic-issues@ietf.org>; Tue, 31 Jul 2018 08:00:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=+JCRGV6HnKMlW/LJnNMyf+QaOdg=; b=X3t2Ap6GTnxGuoLa bKYuqvi3sPZ80XArJuXgNdxtXxkJdgpExKicjXgXj/P4mxGYD0RpX/CWLgumtzU5 NNNkLABBE2z0nMEdvFxfjzCyr/eYMIz2xIM5vqJU3qefKwR6V6F4wMrSLcla1ARY d5wly4bIPyDEP8YhoIT8nNi1M64=
Received: by filter1162p1las1.sendgrid.net with SMTP id filter1162p1las1-14397-5B6079A4-23 2018-07-31 15:00:52.46096436 +0000 UTC m=+492594.952689687
Received: from github-lowworker10-cp1-prd.iad.github.net (unknown [192.30.252.38]) by ismtpd0025p1iad2.sendgrid.net (SG) with ESMTP id BiFaYacdQouOry0Gcuq9Pw for <quic-issues@ietf.org>; Tue, 31 Jul 2018 15:00:52.372 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker10-cp1-prd.iad.github.net (Postfix) with ESMTP id 4C04C3FE29 for <quic-issues@ietf.org>; Tue, 31 Jul 2018 08:00:52 -0700 (PDT)
Date: Tue, 31 Jul 2018 15:00:53 +0000
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc8de3d7fa4839abbb8332246ad1c0580eee08cb492cf0000000117783ba492a169ce149fd7cc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1612/409251712@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1612@github.com>
References: <quicwg/base-drafts/issues/1612@github.com>
Subject: Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6079a449b78_6cbe3ff1a56be6181185c9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0LUKw34T1IAxN+07gGx0aDN2Ale17HbYTDe+ KShpUVIg1jShTluV4XrKALvMEO2pf6VB4sbpWKmc62KJDli9jLkF27OPG1SW6QjKxDi7dIj+MnIxo5 u0+Xh5tnzM53mfnrUd5bQ7xie3t/FCpGdxMMEYklXhckNGWwDC/j3nmtvSJKlFq6JXwuEOwJKVE3qx 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jb-0RVtq0Y-1-6w5ZuNskt_Zc8U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 15:01:02 -0000

@kazuho I don't think we should make it a MUST on the receiver, just a MAY and maybe a MUST on the sender. It is already a MUST, i.e. you MUST not reduce the flow control window.

@dtikhonov of course other bugs are possible, however this is a pretty major one if the sender actually tried to reduce the flow control. Without enforcement the MUST of "sender MUST not reduce the window" is almost impossible to enforce. Ignoring it will just kick the can down the road with such issues only getting discovered way after deployment vs at dev time. 

While I think it's fine to allow senders to copy over the packets that they have sent before, I don't think that should be a goal of QUIC. That is senders that are doing this should be aware of what they are signing for and take appropriate precautions. There are efficient ways to implement copying packets but updating max data. Preventing the efficient enforcement of a clear MUST would be very sad.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1612#issuecomment-409251712