IETF Logo Mail Archive

Re: [quicwg/base-drafts] Adaptive thresholds are useful (#3572)

Martin Thomson <notifications@github.com> Tue, 14 April 2020 22:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C8CF3A11AD for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 15:37:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.649
X-Spam-Level:
X-Spam-Status: No, score=-1.649 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U3qZwsA4wAo2 for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 15:37:45 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9C9D3A11AA for <quic-issues@ietf.org>; Tue, 14 Apr 2020 15:37:45 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id F1A4C8C0DC1 for <quic-issues@ietf.org>; Tue, 14 Apr 2020 15:37:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586903864; bh=FFyfcU6UFEWZ952lcvayRZ69qnZ+RwBMZFqQ4zG8ozo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=quWg/u1qYDZ/vszZEYb0P+NIf0btEstFrMj60YOEopp3nKGMKDVur4G46LPgkIEj5 QZ56dCDOtpQ5oM93PE9Qq6zOvdeiNHo7CWU51l7BGJMiyClNGKE7gNl0ZNldRY0fwB Pau6Rwyf1S6bSchN6VQWGOsQd6YNJk5alHnd1oeo=
Date: Tue, 14 Apr 2020 15:37:44 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2QSMX445A4YVNQVGV4UIODREVBNHHCHD4D3E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3572/review/393343080@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3572@github.com>
References: <quicwg/base-drafts/pull/3572@github.com>
Subject: Re: [quicwg/base-drafts] Adaptive thresholds are useful (#3572)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e963b38e1302_24363fc3d32cd964289063"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/E2im06Y3sQDWFsjpyuWCe4tAQTA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2020 22:37:47 -0000

@martinthomson commented on this pull request.



> @@ -420,8 +420,9 @@ The RECOMMENDED initial value for the packet reordering threshold
 less than 3, to keep in line with TCP {{?RFC5681}}.
 
 Some networks may exhibit higher degrees of reordering, causing a sender to
-detect spurious losses.  Implementers MAY use algorithms developed for TCP, such
-as TCP-NCR {{?RFC4653}}, to improve QUIC's reordering resilience.
+detect spurious losses.  Increasing reordering thresholds after losses
+are spuriously detected have proven useful in TCP, such	as TCP-NCR

```suggestion
are spuriously detected have proven useful in TCP, such as TCP-NCR
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3572#pullrequestreview-393343080

v2.23.0 | Report a Bug | By Email