IETF Logo Mail Archive

[quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)

Lars Eggert <notifications@github.com> Mon, 26 November 2018 10:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3172D130F0D for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 02:15:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oSbQxjZ7vzhU for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 02:15:12 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C5584130F09 for <quic-issues@ietf.org>; Mon, 26 Nov 2018 02:15:11 -0800 (PST)
Date: Mon, 26 Nov 2018 02:15:11 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543227311; bh=87ZeXzLiJXW7K5/Aj4cd3Ar/9Ab6s+yen4k8teium/U=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=X4aAJOwC+kECycNdT/9qQwjn/Xpti5u2PScCdafOdueGVRxBRDs3Sp5gAidU6/Rex NkzUdxWIynywTitdcgYgWFoypiTqMBQ4tsTxUYOTbWJLJQ4KLF4LMaGsfoR4c7MY/q 9BlORWGK3Hg9j2jBiBFFK+aKC/1kHW+MmHJsHi14=
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab35c69300d7de08011f48d695f28f8d7cb12ef1bb92cf00000001181389af92a169ce16e756f7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2052@github.com>
Subject: [quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfbc7af907d_5f503fb9e38d45b41481d2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Kjb-czoxnTuye-lS6r5W2Hq9CJY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Nov 2018 10:15:13 -0000

In `OnPacketSent()`, `time_of_last_sent_retransmittable_packet` is set to `now`, and then `SetLossDetectionTimer()` is called.

In `SetLossDetectionTimer()`, the early RTX timer is computed as `timeout = loss_time - time_of_last_sent_retransmittable_packet`, and `loss_time` can be smaller than `now`, which causes `timeout` to go negative.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2052

v2.23.0 | Report a Bug | By Email