Re: [quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)

[janaiyengar <[e-mail]>]

This could use some clarifying, but that shouldn't happen. loss_time is set to 0 if loss_time is smaller than now, see DetectLostPackets() which sets loss_time. Specifically,
```
    if (time_since_sent > delay_until_lost ||
        delta > reordering_threshold):
      sent_packets.remove(unacked.packet_number)
      if (unacked.retransmittable):
        lost_packets.insert(unacked)
    else if (loss_time == 0 && delay_until_lost != infinite):
      loss_time = now() + delay_until_lost - time_since_sent
```
Since loss_time is *not set* when time_since_sent > delay_until_lost, it remains set to 0. This means an ER timer does not need to be set (and is not set in SetLossDetectionTimer(), which is exactly what you want, since setting a timer only makes sense if the event is in the future. In this case, loss_time was before now(), and so, the loss event happens now, causing OnPacketsLost() to be called at the end of DetectLostPackets().


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2052#issuecomment-441899285