Re: [quicwg/base-drafts] Ekr editorial 17 3 (#2164)

Mike Bishop <notifications@github.com> Thu, 13 December 2018 23:14 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A89D130EA7 for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 15:14:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.781
X-Spam-Level:
X-Spam-Status: No, score=-2.781 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FUZZY_CREDIT=1.678, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L8th0wVRgHbc for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 15:14:53 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 82ED1127AC2 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 15:14:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=YuALB7VWUUKIDZFaTXtuL8S9P10=; b=cLgYEc2kO3Aa702T fdErg0XdG1ucuCVut4YDETuegYMFPbQ1wwqGgYJ68ql5Dvbe8sjinSgOhxkckvh+ ngyggnI4IF0Aox6kIqpbm4H3HIY3AAyjznvMcw1Vd4XgZFbdud317N0haszobpAI UfxS4trplAKOVdoJT7CzhK1JSyU=
Received: by filter0152p1iad2.sendgrid.net with SMTP id filter0152p1iad2-27011-5C12E7EC-2 2018-12-13 23:14:52.130806888 +0000 UTC m=+2965.161388601
Received: from github-lowworker-97d0962.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0008p1iad2.sendgrid.net (SG) with ESMTP id dVafHVJbRpC_WVI4QiiCSw for <quic-issues@ietf.org>; Thu, 13 Dec 2018 23:14:52.156 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-97d0962.cp1-iad.github.net (Postfix) with ESMTP id 1CF8D80D27 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 15:14:52 -0800 (PST)
Date: Thu, 13 Dec 2018 23:14:52 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdab5a93f05ff48648649e71afeb652800f85c46e92cf00000001182aa9ec92a169ce174c6329@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2164/review/184912087@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2164@github.com>
References: <quicwg/base-drafts/pull/2164@github.com>
Subject: Re: [quicwg/base-drafts] Ekr editorial 17 3 (#2164)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c12e7ec1baf0_6bf63fe9262d45c0131246"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1rqLAxIZ/bm7jUyWC17HmDGgpSNhn8KTSHhp U8+6qalDwEbyu4AbOP08NmdhmnChizBnbLUXyUO7UnBGBH9GNNGP5x8yVnvLspqBdy0JmrFfdVfL0p MzPN03BtzJkbKcZ8qJ3unEVDN61LUENnugT3WZda0uGolpU6TNuP6ugZA85bn28kRQihrM5x5YsnmB c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Lj-8mvjBMo7Ts5moBIJKba9vC3s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 23:14:56 -0000

MikeBishop commented on this pull request.



> @@ -3847,10 +3858,11 @@ MUST include the value of the Original Destination Connection ID field of the
 Retry packet (that is, the Destination Connection ID field from the client's
 first Initial packet) in the transport parameter.
 
-If the client received and processed a Retry packet, it validates that the
-original_connection_id transport parameter is present and correct; otherwise, it
-validates that the transport parameter is absent.  A client MUST treat a failed
-validation as a connection error of type TRANSPORT_PARAMETER_ERROR.
+If the client received and processed a Retry packet, it MUST validate
+that the original_connection_id transport parameter is present and
+correct; otherwise, it validates that the transport parameter is
+absent.  A client MUST treat a failed validation as a connection error
+of type TRANSPORT_PARAMETER_ERROR.

Then "otherwise, it MUST validate that...."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2164#discussion_r241596360