IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)

ianswett <notifications@github.com> Fri, 10 May 2019 08:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B234120177 for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 01:16:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.392
X-Spam-Level:
X-Spam-Status: No, score=-1.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j7oguA8aDBiS for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 01:16:48 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C6099120125 for <quic-issues@ietf.org>; Fri, 10 May 2019 01:16:47 -0700 (PDT)
Date: Fri, 10 May 2019 01:16:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557476206; bh=R2ydsFPqQI+ACSR/HMGt1P/sqBNgzIy+E3fxFuuTr1Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zgRIi1fLIjhqchYIS0EjyScQO3KGxphuLLa5z7TfT/nY2h2Vcrxuve6oO9baJCJsI GEnWeuJR6qKLLzSoCM3aoVms4SNIc+NVE/NfFY7AyR4/hB94XJ9FNW2ED5b8OnZOl6 UsnSKaXS7Fm9EsGRLmCcoGVVhEaKBdLHP/tUSTfs=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3K4VCQ5DMIBYVBMJF24JS65EVBNHHBUAC2DE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2642/c491202104@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2642@github.com>
References: <quicwg/base-drafts/pull/2642@github.com>
Subject: Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd5336e9090b_7d173f7e726cd95c5715b9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OH40Ge4gje_scLSUzNSiEFs2JuQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2019 08:16:49 -0000

Now that I've started a PR to combine the crypto handshake timer and PTO, I'm concerned I chose the wrong fix for #2640 in this PR, and it would be better to allow PING in Initial.

In the existing PTO case when there are bytes in flight, but nothing to send, we say "When there is no data to send, the sender SHOULD send a PING or other ack-eliciting frame in a single packet, re-arming the PTO timer."

If we allow PING in Initial, that text will work fine with a combined timer, since all Initials must be in padded datagrams.  Otherwise, combining them adds a slightly odd special case.

@janaiyengar I'd like your thoughts on this in particular.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2642#issuecomment-491202104

v2.23.0 | Report a Bug | By Email