Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)

Marten Seemann <notifications@github.com> Tue, 23 April 2019 14:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E570120033 for <quic-issues@ietfa.amsl.com>; Tue, 23 Apr 2019 07:51:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YRqOdOLU9ohF for <quic-issues@ietfa.amsl.com>; Tue, 23 Apr 2019 07:51:17 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0A3D120385 for <quic-issues@ietf.org>; Tue, 23 Apr 2019 07:51:16 -0700 (PDT)
Date: Tue, 23 Apr 2019 07:51:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556031076; bh=xZv6+6l20ZwpdjkwvhLhh778ksG9KMMfqMmD7HMSK3o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lDmJdKOs/vF99AKhP5vgZ18PZW+PjcEnTgJbRyrr1HGxG/4pkj+XujQBrzL6fylh6 m1wnRmWwMyPLDNkv9WLPglNHWQ8PnmT1zmyIrbJni+h7C5cE7AUk4BpYpZ3Pfm28VZ 4JtCdPhPAl6G3sr1xDg3M3L8QW4GX16klyVRwino=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYQKHFANI4TXFCAAHF2ZRMOJEVBNHHBUAC2DE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2642/review/229603713@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2642@github.com>
References: <quicwg/base-drafts/pull/2642@github.com>
Subject: Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cbf2664120c0_37c43fe0c68cd96c5868f5"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/P399clA7fPuufmucHwE_whTK3q8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2019 14:51:18 -0000

marten-seemann approved this pull request.

There's this weird edge case where you might run out of cwnd, because PADDING counts towards in-flight but is not ack-eliciting, but it seems safe to ignore that one. If you don't receive and acknowledgment for that many packets right at the beginning of the connection, something is going seriously wrong anyway.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2642#pullrequestreview-229603713