Re: [quicwg/base-drafts] Allow endpoints to generate traffic keys asynchronously (#3874)

[Martin Thomson <[e-mail]>]

@martinthomson approved this pull request.

Yes, this is much better.  Shame that it's so big, but that's unavoidable, I think.

>  
-- MUST use the lesser of the value reported in ACK Delay field of the ACK frame
-  and the peer's max_ack_delay transport parameter.
+- MAY ignore the peer's max_ack_delay until the handshake is confirmed,

Do we want to say SHOULD here instead, given that buffering happens?

It means updating pseudocode, but the change is small.

> @@ -1232,10 +1255,7 @@ OnAckReceived(ack, pn_space):
       IncludesAckEliciting(newly_acked_packets)):
     latest_rtt =
       now() - newly_acked_packets.largest().time_sent
-    ack_delay = 0
-    if (pn_space == ApplicationData):
-      ack_delay = ack.ack_delay
-    UpdateRtt(ack_delay)
+    UpdateRtt(ack.ack_delay)

We should change line ~1285 down there vv to:

```
  if handshake confirmed:
    ack_delay = min(ack_delay, max_ack_delay)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3874#pullrequestreview-461266854