Re: [quicwg/base-drafts] Allow endpoints to generate traffic keys asynchronously (#3874)

[Kazuho Oku <[e-mail]>]

@kazuho commented on this pull request.

Thank you for working on this. Looks great to me. I just have one editorial preference, but that's definitely not a blocker.

> @@ -389,6 +398,13 @@ rttvar_sample = abs(smoothed_rtt - adjusted_rtt)
 rttvar = 3/4 * rttvar + 1/4 * rttvar_sample
 ~~~
 
+An endpoint might postpone the processing of acknowledgements when the
+corresponding decryption keys are not immediately available. For example, a
+client might receive an acknowledgement for a 0-RTT packet that it cannot
+decrypt because 1-RTT packet protection keys are not yet available to it. In
+such cases, an endpoint SHOULD ignore such local delays in its round-trip time
+sample until the handshake is confirmed.

I would prefer this section moved above line 358 (i.e. "When adjusting an RTT sample using peer-reported acknowledgement delays, an endpoint:"), and this SHOULD repeated in one of the bullet points, as we do for the ack-delay due to buffering on the receiver side.

That said, I wouldn't be surprised if you chose to do that as a separate editorial path after merging this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3874#pullrequestreview-462119697