IETF Logo Mail Archive

Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)

ianswett <notifications@github.com> Tue, 29 October 2019 21:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 122401201E3 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 14:49:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h14Qskjym8m0 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 14:49:14 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B6CD12001E for <quic-issues@ietf.org>; Tue, 29 Oct 2019 14:49:14 -0700 (PDT)
Date: Tue, 29 Oct 2019 14:49:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572385753; bh=JtlaHwztLWAZowzY5AKkyFe+2lCgUhm6ubmg7VIzTLc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jVVBdLbhkPxjU4KE6IkE4wo3VCksv03mKZ7VLTgZrJdXJ4xpg+yhl03rsuEDe/Oyz UyN6aBBYtDjOrETADJ7cxWN5u45emBxSDW6o11VKJgGsJte1MMFbK2u8nssnKPrNZf VRDPx3mem3kh+NOlHMK8MQT/cUNgU93PASoAlQ9w=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7TX7DPMINNL54DXSV3YX2GTEVBNHHB2737AM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3047/review/308856447@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3047@github.com>
References: <quicwg/base-drafts/pull/3047@github.com>
Subject: Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8b3d970617_52bd3fdc5f4cd968389fe"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VVfugxnGSCQZ1jKMKav8PAHYJOQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 21:49:16 -0000

ianswett commented on this pull request.



>    pto_count = 0
-
   SetLossDetectionTimer()

The ack may update the RTT, so I think we should  keep this unless we add a return value to SendPacketsAsCongestionControllerAllows() indicating whether a packet was sent?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3047#discussion_r340342713

v2.23.0 | Report a Bug | By Email