Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)

[Junho Choi <[e-mail]>]

junhochoi commented on this pull request.



> @@ -1368,7 +1377,15 @@ acked_packet from sent_packets.
        return
      if (congestion_window < ssthresh):
        // Slow start.
-       congestion_window += acked_packet.size
+       if (pacing):
+         congestion_window += acked_packet.size
+       else:
+         // If pacing is not used, limit the increase to
+         // 2*max_datagram_size per ACK as described in
+         // {{?RFC3465}}
+         if (cwnd_increase < 2 * max_datagram_size):
+           cwnd_increase += bytes_acked
+           congestion_window += bytes_acked

I mean this part:

> congestion_window = cwnd_increase

If you run my example above (3 acks 999 bytes each), cwin will be 2 x mss at the end with algorithms above.

I think you mean `+=`, not `=`, but if so it makes another issue (cwin will increase much faster than expected)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3232#discussion_r346628814