Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Junho Choi <notifications@github.com> Fri, 15 November 2019 01:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
by ietfa.amsl.com (Postfix) with ESMTP id A0DF41200A1
for <quic-issues@ietfa.amsl.com>; Thu, 14 Nov 2019 17:34:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404,
HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id its5lb-6IPDm for <quic-issues@ietfa.amsl.com>;
Thu, 14 Nov 2019 17:34:55 -0800 (PST)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by ietfa.amsl.com (Postfix) with ESMTPS id 6DC5912009E
for <quic-issues@ietf.org>; Thu, 14 Nov 2019 17:34:55 -0800 (PST)
Received: from github-lowworker-19d82f6.ac4-iad.github.net
(github-lowworker-19d82f6.ac4-iad.github.net [10.52.16.75])
by smtp.github.com (Postfix) with ESMTP id 069F52615AB
for <quic-issues@ietf.org>; Thu, 14 Nov 2019 17:34:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1573781695;
bh=XkRtoQ3AjGDpo+oK3LEx8pAPAOgTo0qD2h6xR8T4d9E=;
h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=v3t2ypVGDbFecTPeLooyshURMzcpLJqCeyCUC6h7BJ6LvGsYNh56zZjETp7dC8OHy
PdvROmQHf59OOiLeHzW7tfTzc1RpvAvSWTrc9H9dUjHuuv4Yv8bYjZ+W6184DGTw1r
yBX/Q9Z2ZlBgp57eHLAsCV56SPtKHW25tQNLgd5M=
Date: Thu, 14 Nov 2019 17:34:54 -0800
From: Junho Choi <notifications@github.com>
Reply-To: quicwg/base-drafts
<reply+AFTOJKZYCIAS224FH35YVYN33MZT5EVBNHHB6GTRAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3232/review/317365698@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3232@github.com>
References: <quicwg/base-drafts/pull/3232@github.com>
Subject: Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5dce00beb63d6_2a9c3fe9ec6cd96c150993";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: junhochoi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/X6Oyhq4A_Kcmv4-rjONcnOoN5L4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
<quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
<mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
<mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Nov 2019 01:34:57 -0000
junhochoi commented on this pull request. > @@ -1368,7 +1377,15 @@ acked_packet from sent_packets. return if (congestion_window < ssthresh): // Slow start. - congestion_window += acked_packet.size + if (pacing): + congestion_window += acked_packet.size + else: + // If pacing is not used, limit the increase to + // 2*max_datagram_size per ACK as described in + // {{?RFC3465}} + if (cwnd_increase < 2 * max_datagram_size): + cwnd_increase += bytes_acked + congestion_window += bytes_acked I mean this part: > congestion_window = cwnd_increase If you run my example above (3 acks 999 bytes each), cwin will be 2 x mss at the end with algorithms above. I think you mean `+=`, not `=`, but if so it makes another issue (cwin will increase much faster than expected) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3232#discussion_r346628814
- [quicwg/base-drafts] Limit CWND increase in slow … Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Martin Thomson
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel