IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPONSE frames, avoid buffering (#2729)

Martin Thomson <notifications@github.com> Fri, 14 June 2019 02:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C24FA12010E for <quic-issues@ietfa.amsl.com>; Thu, 13 Jun 2019 19:22:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.463
X-Spam-Level:
X-Spam-Status: No, score=-6.463 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c4X1isJfe5Tz for <quic-issues@ietfa.amsl.com>; Thu, 13 Jun 2019 19:22:53 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 978C51200F9 for <quic-issues@ietf.org>; Thu, 13 Jun 2019 19:22:53 -0700 (PDT)
Date: Thu, 13 Jun 2019 19:22:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560478972; bh=VFMbMli1blI19PApD8tonRG70GitH58H4hPpVolDHCg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pIKbVRMmLZdQUKryamcDmAIsEGAmRvzLuQQbKU8Hd5z9BRqyPz5FHHn2OyqtlQdbN 2Y3FSTbAb/6rNtqgQ5lXdtLDQHsQpSTi8G4Z5I9M0tfHZ0Rv5WmW8ioqmHFsk5Om2G 8w1fx/pQoyRl9EckGagVdU7Rp3Z+7cyxQiNEe+WY=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3EDYKDFDKXVTEK3FN3CA3XZEVBNHHBVGEZF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2729/c501943552@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2729@github.com>
References: <quicwg/base-drafts/pull/2729@github.com>
Subject: Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPONSE frames, avoid buffering (#2729)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0304fc3f59b_11a53ff5186cd96c3134c2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iigrAbBk9mFNuhMWKUDyYCyvnD0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jun 2019 02:22:56 -0000

I took the liberty of making the change proposed by Kazuho here.

I did not make a change to prohibit sending multiple PATH_RESPONSE per packet.  As others have pointed out, that makes processing packets for sending more complex than is ideal.  The text allowing these frames to be dropped is fine.

If someone disagrees with this, then I think it would be best to take that discussion up in a new issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2729#issuecomment-501943552

v2.23.0 | Report a Bug | By Email